Update Contests System#583
Merged
OldDanceJacket merged 3 commits intoSimple-Station:masterfrom Jul 24, 2024
Merged
Conversation
DEATHB4DEFEAT
approved these changes
Jul 24, 2024
Co-authored-by: DEATHB4DEFEAT <77995199+DEATHB4DEFEAT@users.noreply.github.com> Signed-off-by: VMSolidus <evilexecutive@gmail.com>
OldDanceJacket
approved these changes
Jul 24, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR massively expands upon the functionality of the Contests System, fully restoring it not only to the original level of functionality available to the Nyanotrasen Contests, but vastly exceeding its functionality too. Contests now include features like Health Contests, Stamina Contests, but also include hooks for Mind Contests (To allow other systems to implement theoretical effects of MindContest even though I'm not yet finished with the Psionic Refactor).
Additionally, all Contests now include optional overrides, allowing other functions to modify their own expected outcomes from the ContestsSystem. These two optional overrides are:
Changelog
No changelog because this is completely zero player-facing implementations. All I have done is give DEVS the tools needed to begin implementing easy math into the game.