Adds PKA & Jetpack Module for Salvage Cyborgs

[gluesniffler]

Description

Gives salvage borgs a special jetpack module with half of the capacity of a normal mini-jetpack. Granting them about 2 minutes of thrust, which allows them to be more useful in space, partake in some rescue missions and to some extent be independent for a limited amount of time if something happens to the salvagers.

It also adds a PKA module, which gives them a PKA which can't be wielded, leading to a hilarious accuracy penalty.

---

Media

Demo of the Modules

Stormtrooper aim vs dragon AI

Refillable jetpack module demo

---

Changelog

🆑

• add: Added an unlockable PKA and Jetpack module to Salvage Cyborgs

[github-actions]

RSI Diff Bot; head commit 6ce6a39 merging into a31015d
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/Objects/Specific/Robotics/borgmodule.rsi

State	Old	New	Status
icon-jetpack			Added
icon-pka			Added

Edit: diff updated after 6ce6a39

[DangerRevolution]

How do you refill the jetpack?

[gluesniffler]

How do you refill the jetpack?

Special, non-refillable jetpack module.

Reasoning for this is mostly balancing, refilling the module would require help from someone with hands anyway, and since jetpacks inherit from tanks, they don't seem to have any gas whitelisting, so I cannot prevent players from just stuffing it with liquid oxygen to make 'em last a ridiculous amount of time.

The point is to just give salv borgs a lil' bit more independence and not make them bricks you have to drag around at all times (the current state), thus you might as well just send the borgs off to Epi periodically if they want refills. Happy to adjust values for crafting cost/thrust duration with this in mind.

[VMSolidus]

How do you refill the jetpack?

Special, non-refillable jetpack module.

Reasoning for this is mostly balancing, refilling the module would require help from someone with hands anyway, and since jetpacks inherit from tanks, they don't seem to have any gas whitelisting, so I cannot prevent players from just stuffing it with liquid oxygen to make 'em last a ridiculous amount of time.

The point is to just give salv borgs a lil' bit more independence and not make them bricks you have to drag around at all times (the current state), thus you might as well just send the borgs off to Epi periodically if they want refills. Happy to adjust values for crafting cost/thrust duration with this in mind.

Reasoning behind this is somewhat faulty. There's no such thing as Liquid Oxygen, it's just an oxygen canister that contains double the volume of oxygen, but cannot itself be refilled to that volume, and cannot overpressure people's air tanks. It really should just be renamed to "Double-capacity Oxygen Canister".

[gluesniffler]

Reasoning behind this is somewhat faulty. There's no such thing as Liquid Oxygen, it's just an oxygen canister that contains double the volume of oxygen, but cannot itself be refilled to that volume, and cannot overpressure people's air tanks.

Liquid Oxygen Is Different.

For any readers who come in later, Liquid Oxygen is not just double the volume of oxygen, but is also chilled to a very low temperature, which leads to being able to fit more mols in a container as per Boyle's Law as seen in the image below, in jetpack calculations, this extends flight duration. In the case of this particular jetpack's capacity, thrust time would go from 2 minutes to about 6:30 minutes.

Constraints

If it's not a balance concern, I'm all for letting brogs get their jetpacks refilled, but after doing some digging on the system itself, there's also constraints in how their modules handle items, particularly:

1. The items are only created when in a Borg's possession, so until its inserted into a borg, the jetpack doesn't exist, and they cannot drop their items.
2. Borgs can only use whats inside of the module, so giving the module itself a Jetpack attribute is not good enough.

Options to improve?

1. Just change the thrust duration to either match a Mini Jetpack (4min), or the duration on liquid oxy (6:30min).
2. Hack around the GasCanisterSystem so it accepts this particular module and allows for refill... And if it hasn't been inserted into a borg beforehand, initialize its contents directly (is this shitcode?),

(Edited as of 7/21/24 to reflect the more reasonable options that I could get working) Will update with another commit soon ™️

[gluesniffler]

Added a refillable feature to the jetpack module, in summary it checks for the prototypes of items to be created when modules are inserted on cyborgs, and if its got a BorgJetpackComponent it will add the UID of the jetpack to a variable. This is then used on GasCanisterSystem whenever something is inserted, refilled or displayed in the UI to make sure modules are handled correctly.

Couldn't get a way to make it so that the contents would be initialized on item creation, the methods currently require an existing borg chassis to do so.