Invert the Running/Walking States#485
Invert the Running/Walking States#485DangerRevolution merged 8 commits intoSimple-Station:masterfrom
Conversation
Simple-Station/Parkstation#193 🆑 - tweak: The station's crew hivemind has decided to slow down their movement and enjoy The Park instead of sprinting everywhere
DEATHB4DEFEAT
added
Size: 4-Small
github-actions
bot
added
Changes: C#
|
Im not a fan of this change, i like the shift to slow down because else mostly nearly everyone is going to hold shift to just walk, and that just may be annoying. |
Use toggle sprint or slow down and enjoy The Park. |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
|
Added a description explaining rationale. |
| ui-options-function-move-down = Move Down | ||
| ui-options-function-move-right = Move Right | ||
| ui-options-function-walk = Walk | ||
| ui-options-function-walk = Run |
There was a problem hiding this comment.
Don't know why this is the engine. I can't change this.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
This comment was marked as resolved.
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Signed-off-by: DEATHB4DEFEAT <[email protected]>
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
VMSolidus
left a comment
VMSolidus
left a comment
There was a problem hiding this comment.
Actually went through and read the code this time. This is good. :)
| //NOTE I don't think I'm supposed to do this | ||
| public bool Sprinting => IoCManager.Resolve<IConfigurationManager>().GetCVar(CCVars.GameSprintWalks) | ||
| ? (HeldMoveButtons & MoveButtons.Sprint) != 0x0 | ||
| : (HeldMoveButtons & MoveButtons.Sprint) == 0x0; |
There was a problem hiding this comment.
There's logic in my Components!
Yeah, this isn't ideal, Component should just hold the state. This is also a really goofy way of doing it. You're also querying the CVar every single time this is checked, which doesn't seem ideal?
|
|
||
| ui-options-hotkey-keymap = Use US QWERTY Keys | ||
| ui-options-hotkey-toggle-walk = Toggle Walk | ||
| ui-options-hotkey-toggle-walk = Toggle Speed |
There was a problem hiding this comment.
Not quite sure about this, same reason with it being an optional change. You could make two separate Loc strings, one for walk and one for sprint, that wouldn't be unreasonable.
There was a problem hiding this comment.
It's an engine bind, I cannot make it switch between two locales.
Co-authored-by: Pspritechologist <[email protected]> Signed-off-by: DEATHB4DEFEAT <[email protected]>
6 participants
Description
Ports Simple-Station/Parkstation-Friendly-Chainsaw#39
A change made to encourage people to stop and smell the roses, instead of sprinting everywhere trying to get shit done.
This goes well with #486, so people don't actually have to rush places to try to get things done before the shift ends fatally.
It's weird anyway how we're all constantly sprinting everywhere and have to very actively choose not to (and why would you?).
Increases the default speeds so that walking isn't painfully slow and sprinting feels more like sprinting in combination with the active choice to sprint.
Someone needs to PR changing the default sprint or examine buttons, so people can fight and sprint with this change.
(A lot of other default keybinds suck or conflict too and need to change)
Media
Terrible video but whatever
2024-07-20_00-12-13.mp4
Changelog
🆑