Revert Salvage Shittle and Trading Post removal#344
Merged
Peptide90 merged 1 commit intoSimple-Station:masterfrom Apr 30, 2024
Merged
Revert Salvage Shittle and Trading Post removal#344Peptide90 merged 1 commit intoSimple-Station:masterfrom
Peptide90 merged 1 commit intoSimple-Station:masterfrom
Conversation
Contributor
|
not sure this is a good idea, forks should be able to edit this to their preference :O |
Contributor
|
Make it a cvar :godo: Also forks still can, this is just the default |
Peptide90
approved these changes
Apr 30, 2024
DangerRevolution
approved these changes
Apr 30, 2024
Contributor
DangerRevolution
left a comment
DangerRevolution
left a comment
There was a problem hiding this comment.
i personally don't like this but it is a functional PR, this should be checked that it causes no fuckery with changed bounties from Delta
This comment was marked as abuse.
This comment was marked as abuse.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
Member
Author
Everything still works, there's just two trade stations now. I'll go fix that. |
Peptide90
pushed a commit
that referenced
this pull request
May 12, 2024
# Description This fixes a bug introduced inadvertently by #344 by adding a CVar that makes it a choice to be made by our downstreams. Also, welcome to our new CVar standard where they should be included in other systems. --------- Co-authored-by: Danger Revolution! <[email protected]>
Mnemotechnician
pushed a commit
to Mnemotechnician/Einstein-Engines
that referenced
this pull request
Dec 15, 2024
Herbals Don't Contain Nicotine
Mnemotechnician
pushed a commit
to Mnemotechnician/Einstein-Engines
that referenced
this pull request
Dec 15, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's been gone for a bit too long.