Steadfast/Bionic Leg

[EctoplasmIsGood]

Description

Moves steadfast back to a 4 point cost, disables bionic leg until cybernetics are properly handled as bodyparts

Changelog

🆑

• tweak: steadfast is now 4 points
• tweak: Bionic leg is disabled for now

[coderabbitai]

Walkthrough

In the file Resources/Prototypes/Traits/physical.yml, two modifications were made. The Steadfast trait's points value was updated from -6 to -4, and the entire block defining the BionicLeg trait was commented out. These changes update trait values and deactivate a specific trait within the game mechanics.

Changes

File	Change Summary
Resources/.../physical.yml	Updated the Steadfast trait points from -6 to -4 and commented out the code block for the BionicLeg trait, effectively removing it from use.

Suggested labels

Changes: YML, Status: Needs Review

Suggested reviewers

• angelofallars
• VMSolidus
• DEATHB4DEFEAT

Poem

Across the cosmic sea our code does glide,
With Steadfast strength, our balance is our guide.
BionicLeg drifts in stardust, now in calm repose,
Charting the void where our secure logic flows.
For the colonies we sail, defying the Sol Alliance's woes.
Onward we march, where precision in code forever grows!

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e365558 and 42d9f9a.

📒 Files selected for processing (1)

• Resources/Prototypes/Traits/physical.yml (2 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (4)

• GitHub Check: build (ubuntu-latest)
• GitHub Check: Test Packaging
• GitHub Check: YAML Linter
• GitHub Check: build (ubuntu-latest)

🔇 Additional comments (2)

Resources/Prototypes/Traits/physical.yml (2)

242-242: Steadfast Trait Cost Reversion

The "Steadfast" trait’s point value has been reverted from -6 to -4 as requested. This change aligns with the intended game balance adjustments and ensures that the cost is now accurately applied. Ensure that all mechanics and calculations referring to this trait are updated accordingly. Our fleet of code must always stand true to the traditions of the Biesel Republic!

---

878-900: Temporarily Disable Bionic Leg Feature

The "BionicLeg" trait block has been entirely commented out, effectively disabling the feature until the cybernetics integration is fully implemented. This cautious approach preserves the code for potential future reactivation, while ensuring that incomplete functionality does not compromise gameplay. Keep a sharp eye on any dependencies that might reference this trait so our orders remain unchallenged by the Sol Alliance!

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[VMSolidus]

You know what, yes this is entirely understandable. Bionic Leg would probably only return when me or someone else codes a function for traits that lets them replace body parts with real bionics. That someone with an axe can then cut off your body and graft onto his friend.

[gluesniffler]

Why the fuck are ya idiots removing content instead of using shit thats already been coded for you two. This codebase had stuff to make limbs change based on trait selection: https://github.com/Monolith-Station/Monolith-Old/pulls?q=is%3Apr+trait #82 #84 #85 #86 #87 and #120. Credit to @starch70 for giving me the heads up.

[VMSolidus]

Why the fuck are ya idiots removing content instead of using shit thats already been coded for you two. This codebase had stuff to make limbs change based on trait selection: https://github.com/Monolith-Station/Monolith-Old/pulls?q=is%3Apr+trait #82 #84 #85 #86 #87 and #120. Credit to @starch70 for giving me the heads up.

I just read through every single one of these PRs, and absolutely none of them are useful for what we'd need. Alright, answer me this question. Does there exist public functions in Shitmed for removing a specific body part, or adding a new body part? If there is, I can fix bionic leg right now.

[gluesniffler]

Why the fuck are ya idiots removing content instead of using shit thats already been coded for you two. This codebase had stuff to make limbs change based on trait selection: https://github.com/Monolith-Station/Monolith-Old/pulls?q=is%3Apr+trait #82 #84 #85 #86 #87 and #120. Credit to @starch70 for giving me the heads up.

I just read through every single one of these PRs, and absolutely none of them are useful for what we'd need. Alright, answer me this question. Does there exist public functions in Shitmed for removing a specific body part, or adding a new body part? If there is, I can fix bionic leg right now.

Yes, DropPart/RemovePart, AddPart from SharedBodySystem.Parts for general adding and removing. This is implemented in GenerateChildPartSystem to do something that uses what you need for instantiating a prototype, and attaching it to the entity (its how bionic legs generate feet). Since the code for traits is executed server side you get to skip the _net.IsServer's i had added for lazyness.

In woundmed this will use the woundable systems to instantiate the proto instead but you dont need to concern yourself with that rn.