Bluespace and Normality Tweaks/Fixes + Bluespace Part Crafting#1052
Merged
VMSolidus merged 8 commits intoSimple-Station:masterfrom Oct 16, 2024
Merged
Bluespace and Normality Tweaks/Fixes + Bluespace Part Crafting#1052VMSolidus merged 8 commits intoSimple-Station:masterfrom
VMSolidus merged 8 commits intoSimple-Station:masterfrom
Conversation
SimpleStation14
changed the title
Contributor
|
RSI Diff Bot; head commit bb8bf97 merging into 6cbaf2f Resources/Textures/Objects/Materials/materials.rsi
Resources/Textures/Objects/Materials/ore.rsi
|
ShadesMars
requested review from
a team,
DEATHB4DEFEAT,
OldDanceJacket,
Peptide90,
Pspritechologist,
ShadesMars and
VMSolidus
and removed request for
a team
ShadesMars
approved these changes
Oct 15, 2024
Contributor
ShadesMars
left a comment
ShadesMars
left a comment
There was a problem hiding this comment.
While im gona approve this, there is some misc pehaps little changes that il request tho i will not make them important at all.
Resources/Textures/Nyanotrasen/Objects/Materials/materials.rsi/meta.json
Outdated
Show resolved
Hide resolved
ShadesMars
added
Priority: 2-High
ShadesMars
suggested changes
Oct 15, 2024
Contributor
ShadesMars
left a comment
ShadesMars
left a comment
There was a problem hiding this comment.
Oh yeah and tests fails valid.
Contributor
Author
Oops! mistell. |
Contributor
|
Ehh.... |
ShadesMars
previously requested changes
Oct 15, 2024
Contributor
ShadesMars
left a comment
ShadesMars
left a comment
There was a problem hiding this comment.
Test Fails still valid.
"CoreSilver Duplicated?"
Contributor
Author
wasnt me |
Contributor
I know but others tests are valid. |
Aidenkrz
changed the title
SimpleStation14
changed the title
Contributor
Author
|
I invoke the power of "running yamllinter locally before re-requesting review!" |
Contributor
Its is done |
github-actions
bot
added
Changes: Localization
VMSolidus
approved these changes
Oct 16, 2024
DEATHB4DEFEAT
approved these changes
Oct 16, 2024
Co-authored-by: DEATHB4DEFEAT <[email protected]> Signed-off-by: Aiden <[email protected]>
Co-authored-by: DEATHB4DEFEAT <[email protected]> Signed-off-by: Aiden <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Bluespace crystals would turn into ore when ejected from autolathe, lead me down a rabbit hole of issues with them.
Fixes #980
Media
Changelog
🆑