Constrict Height and Width via a Size Ratio & Fix Humanoids Not Having A Fixture#1049
Merged
VMSolidus merged 12 commits intoSimple-Station:masterfrom Oct 16, 2024
Merged
Conversation
github-actions
bot
added
Changes: C#
Contributor
|
Yooo goober first PR |
ShadesMars
requested review from
a team,
DEATHB4DEFEAT,
OldDanceJacket,
Peptide90,
Pspritechologist,
ShadesMars and
VMSolidus
and removed request for
a team
ShadesMars
added
Size: 4-Small
Contributor
Author
I mean.... if you dont count my ghost bar that is in PR limbo currently here. |
Contributor
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
1 similar comment
Contributor
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Contributor
Author
|
yeah uh discovered a bug i accidentally introduced while fixing merge conflicts, all good now tho |
Aidenkrz
changed the title
VMSolidus
requested changes
Oct 15, 2024
Co-authored-by: VMSolidus <evilexecutive@gmail.com> Signed-off-by: Aiden <aiden@djkraz.com>
Co-authored-by: VMSolidus <evilexecutive@gmail.com> Signed-off-by: Aiden <aiden@djkraz.com>
ShadesMars
added
Priority: 2-High
Aidenkrz
changed the title
VMSolidus
approved these changes
Oct 15, 2024
Member
VMSolidus
left a comment
VMSolidus
left a comment
There was a problem hiding this comment.
Imagine a world where my maintainers reviewed the PR that fixes the tests
DEATHB4DEFEAT
approved these changes
Oct 16, 2024
Co-authored-by: DEATHB4DEFEAT <77995199+DEATHB4DEFEAT@users.noreply.github.com> Signed-off-by: Aiden <aiden@djkraz.com>
ShadesMars
approved these changes
Oct 16, 2024
SimpleStation14
added a commit
that referenced
this pull request
Oct 16, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Title
Intended to stop players from making slender men type characters with height maxed and width at the minimum, and vice versa
The ratio can be modified via the species' prototype
Also fixes the issue of players being able to noclip because they're fixture has no radius by setting the Height and Width to the species default if none is provided. (technically this also fixes Urists always being as small as possible)
Solves #865 #497
Partially resolves #995
Media
d88dfda0bc18264689ba1fca3c6a0e86.mp4
Changelog
🆑