Skip to content

Port Gax From Estação Pirata#1019

Merged
VMSolidus merged 15 commits intoSimple-Station:masterfrom
EmilyCoelhoBR:PortGaxstation
Oct 9, 2024
Merged

Port Gax From Estação Pirata#1019
VMSolidus merged 15 commits intoSimple-Station:masterfrom
EmilyCoelhoBR:PortGaxstation

Conversation

@EmilyCoelhoBR
Copy link
Copy Markdown
Contributor

Description

This PR ports the "Gax" map directly from Estação Pirata, making some changes and corrections.
This PR ports rbertoche/space-station-14#80
Gax is a recreated ss13 map, originally from YogStation (SS13)


TODO


Media

Gax-0


Changelog

🆑

  • add: A new map called NCS Gax has been added to rotation.

@github-actions github-actions bot added Changes: C# Changes any cs files Changes: Map Changes any yml file in the Maps directories labels Oct 7, 2024
@SimpleStation14 SimpleStation14 changed the title Port Gax from Estação Pirata Port Gax From Estação Pirata Oct 7, 2024
@ShadesMars ShadesMars requested review from a team, DEATHB4DEFEAT, OldDanceJacket, Peptide90, Pspritechologist, ShadesMars and VMSolidus and removed request for a team October 7, 2024 19:41
@github-actions github-actions bot added Status: Needs Review Someone please review this labels Oct 7, 2024
@ShadesMars ShadesMars added Priority: 3-Medium Needs to be resolved at some point and removed Status: Needs Review Someone please review this labels Oct 7, 2024
@github-actions github-actions bot added the Status: Needs Review Someone please review this label Oct 7, 2024
@ShadesMars ShadesMars added Size: 3-Medium For medium issues/PRs Type: Port Brings something to here from another codebase labels Oct 7, 2024
@VMSolidus
Copy link
Copy Markdown
Member

VMSolidus commented Oct 8, 2024

So I don't normally do map reviews, but luckily they aren't that crazy to do since it's pretty self evident if a map is good or not(to me at least), and I have a checklist of things our maps will need. So I'll start off with the Good, the Amazing, the Okay, and the Missing Content.

Good!
The layout of this map is awesome, and I appreciate that pretty much every department has their own special interactions for a lot of things. The fully enclosed arrivals dock with meteor shielding is PEAK. I've never seen a map with that before. All of the departments except for Epistemics are incredibly spacious.

Awesome:
I will admit, that in exchange for Epistemics feeling more cramped than the other departments, you have completely knocked it out of the fucking park by futureproofing the map for content that isn't even in the game yet, by including things such as an AI Satellite, a Xenobiology lab, an AI Upload Room(Separate from the Satellite), a fully stocked Robotics Bay with Surgical Room, Server room completely separate from the Mystagogue's office is great.

You have probably the best medbay I've ever seen in a map. Congratulations on absolutely killing it here. Having Virology, Genetics, Security Checkpoint, Chemistry, Cloning Lab, Cryo bay, Surgery Room, and hell there's even a break room, and a Paramedic checkpoint! There is very little this medbay is missing!

Okay:
Security can stand to be improved most, but luckily its improvements aren't that crazy. I absolutely love that Security has a shuttle dock, presumably in preparation for things like Lavaland Deportation. That's awesome!

The Permabrig could probably be livened up a little, it's unusually barebones I will admit.
image

Armory is unusually vulnerable: Lastly, the Armory has a potential access route that would allow for breaching the armory to space via only a single C4. There should be an extra layer of walls on the outside of the armory, which will prevent the armory from being entered with only a single C4. It's important for game balance that Security have time to react when they first hear the beeping that indicates Nukies are trying to take the Armory.
image

Missing Content:
Okay, here's where the nit and gritty needs to happen.

Missing Oracle: We require that the entity called Oracle(A statue usually paired with Sophia) be placed somewhere on the map, preferably in the Science/Epistemics lobby. It can also in a pinch be in the Chapel. But it must be publicly accessible.
image

Missing Biomass Reclaimer Drain: The biomass reclaimer is in an odd spot, placed inside the cloning bay. Usually we'd see it tucked away in the morgue. But I'm not going to ask you to move the reclaimer all the way to the morgue seeing as it's on the exact opposite side of the medbay. It'll just need to have a Drain placed under or in front of it.

Missing Forensic Mantis: We require a space be added for the ForensicMantis role be placed somewhere in the map, as well as a Job Spawner for the role. Given the map's unusual layout, you will probably want to convert one of the Maintenance Rooms into a sort of office/drugden for the Mantis to spawn in. Either of these two rooms are suitable(Although the second room may need to be expanded 1 or 2 tiles down):
image

image

Science-Security Checkpoint is Inaccessible: This security checkpoint into Science cannot be reached by Security officers. This could be rectified by adding a Security airlock door leading into Maintenance.
image

Artifact Lab is missing Wall-Mounted Geiger Counters:
image

@rbertoche
Copy link
Copy Markdown
Contributor

Nice PR!
So I won't comment anything regarding actually reviewing the map but:
It's been under active maintenance and running on our servers since last June at least, so there's been plenty of time to polish sharp edges. Maybe there's stuff that may have appeared after we switched to playing on an Einstein Engines branch about a month ago, there's stuff that you already reviewed up there that could use improvements, but it's safe to expect no game breaker issues, plus we're running it on EE for about a month.
Cheers

@rbertoche
Copy link
Copy Markdown
Contributor

rbertoche commented Oct 8, 2024

Can't miss the opportunity to say the map is awesome though, me myself and players in general like it! It's surely been a milestone on original map recreations on Pirata, thanks to @Ichaie, also others but I think credit goes almost entirely to Ichai.

@VMSolidus
Copy link
Copy Markdown
Member

In any case, the changes I've requested are small and easy to do, so I don't mind approving this after they're done. :)

@VMSolidus
Copy link
Copy Markdown
Member

Also the map yml has some "INVALID" entries in it. Those will need to be deleted.

@EmilyCoelhoBR
Copy link
Copy Markdown
Contributor Author

imagem_2024-10-08_200311191
imagem_2024-10-08_200347614
image
@VMSolidus Here are some images of the changes to the map

@VMSolidus
Copy link
Copy Markdown
Member

Oh my gosh that Permabrig is gorgeous now.

@VMSolidus
Copy link
Copy Markdown
Member

image

Looks like it needs to have a spawn point added for the medical borg. But all the rest of the tests are fine. :)

@VMSolidus VMSolidus merged commit b0262f3 into Simple-Station:master Oct 9, 2024
SimpleStation14 added a commit that referenced this pull request Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Changes: C# Changes any cs files Changes: Map Changes any yml file in the Maps directories Priority: 3-Medium Needs to be resolved at some point Size: 3-Medium For medium issues/PRs Status: Needs Review Someone please review this Type: Port Brings something to here from another codebase

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants