Fix docker build. Changing agbenchmark dependency as git reference instead of folder reference.#6274
Merged
Pwuts merged 2 commits intoSignificant-Gravitas:masterfrom Nov 24, 2023
Merged
Conversation
Changing agbenchmark dependency as git reference instead of folder reference.
✅ Deploy Preview for auto-gpt-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Member
|
We strongly prefer to have it as a path dependency because that allows more agility in developing the packages in the repo. Also, we have a fix on the way: python-poetry/poetry#8549 I'll look into adopting (part of) your fix in the meantime, as the main issue that I'm trying to avoid is dependency insolvency between autogpt and forge. |
Member
|
Thank you! |
This was referenced Nov 24, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changing agbenchmark dependency as git reference instead of folder reference.
Background
When building the autogpt docker image, then only the autogpts/autogpt folder is copied into the Docker image.
So, when
poetry install --roottries to install the dependencies in the image, it will not work, because thebenchmarkfolder is not in the image. As JulianBroudy's commented the logs under #5253. So, I changed the dependency to a git reference which makes the agbenchmark accessible from the Docker image.Related issues:
Changes 🏗️
poetry update agbencmarkto update thepoetry.lockfile.poetry update agbencmarkto update thepoetry.lockfile.PR Quality Scorecard ✨
+2 pts+5 pts+5 pts+5 pts-4 pts+4 pts+5 pts-5 ptsagbenchmarkto verify that these changes do not regress performance?+10 pts