Skip to content

Conversation

@rochlefebvre
Copy link
Contributor

@rochlefebvre rochlefebvre commented May 13, 2024

What are you trying to accomplish?

Using worldwide 0.11.1 from source at `.`
Gem::Ext::BuildError: ERROR: Failed to build gem native extension.

current directory:
/app/data/bundler/ruby/3.3.0/gems/stringio-3.0.6/ext/stringio
/usr/local/ruby/bin/ruby extconf.rb
checking for rb_io_extract_modeenc() in ruby/io.h... yes
creating Makefile
...
compiling stringio.c
stringio.c: In function ‘strio_init’:
stringio.c:359:24: error: storage size of ‘convconfig’ isn’t known
     struct rb_io_enc_t convconfig;
                        ^
stringio.c:359:24: warning: unused variable ‘convconfig’ [-Wunused-variable]
stringio.c: In function ‘strio_set_encoding’:
stringio.c:1822:25: error: storage size of ‘convconfig’ isn’t known
      struct rb_io_enc_t convconfig;
                         ^
stringio.c:1822:25: warning: unused variable ‘convconfig’ [-Wunused-variable]
stringio.c: At top level:
cc1: warning: unrecognized command line option ‘-Wno-tautological-compare’
cc1: warning: unrecognized command line option ‘-Wno-self-assign’
cc1: warning: unrecognized command line option ‘-Wno-parentheses-equality’
cc1: warning: unrecognized command line option ‘-Wno-constant-logical-operand’
cc1: warning: unrecognized command line option ‘-Wno-cast-function-type’
Makefile:247: recipe for target 'stringio.o' failed
make: *** [stringio.o] Error 1
make failed, exit code 2

Which is very close to ruby/stringio#54, fixed as part of stringio 3.0.7, a release that adds support for Ruby 3.3.

What approach did you choose and why?

Bump stringio to the latest release.

Checklist

  • I have added a CHANGELOG entry for this change (or determined that it isn't needed)

@rochlefebvre rochlefebvre force-pushed the release-0.11.1-take-2 branch from 4d26995 to 4d969a3 Compare May 13, 2024 15:01
@rochlefebvre rochlefebvre marked this pull request as ready for review May 13, 2024 15:02
@rochlefebvre rochlefebvre requested a review from a team May 13, 2024 15:02
Copy link
Contributor

@devanandersen devanandersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me!

@devanandersen devanandersen requested a review from a team May 13, 2024 15:04
@rochlefebvre rochlefebvre merged commit f60fab8 into main May 13, 2024
@rochlefebvre rochlefebvre deleted the release-0.11.1-take-2 branch May 13, 2024 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants