Require the Sorbet version that started supporting T.anything#1302
Merged
Require the Sorbet version that started supporting T.anything#1302
T.anything#1302Conversation
andyw8
approved these changes
Jan 12, 2024
vinistock
approved these changes
Jan 12, 2024
Member
vinistock
left a comment
vinistock
left a comment
There was a problem hiding this comment.
Does this version also support T::Class? If so, then there are a couple of places where we might be able to improve typing. Not on this PR though.
Member
Author
|
@vinistock I think |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Without this, projects using older Sorbet versions can hit
NoMethodErrorwhen theT.anythingsignature is hit, as shown in #1300.Closes #1300
Implementation
Bump the version requirement of
sorbet-runtimeingemspec.Automated Tests
Manual Tests