Skip to content

Fix Chrome headless #936

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
etiennebarrie merged 2 commits into from
Dec 18, 2023
Merged

Fix Chrome headless #936

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3aa568d
Use new headless Chrome
etiennebarrie Dec 15, 2023
730a070
Allow 6.0 to use --headless=new
etiennebarrie Dec 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions test/application_system_test_case.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,11 @@

if Rails::VERSION::MAJOR < 7
Selenium::WebDriver.logger.ignore(:browser_options)
if Rails::VERSION::MINOR < 1
require "action_dispatch/system_testing/browser"
# prevent Rails from adding --headless at the end of the arguments, overriding --headless=new
ActionDispatch::SystemTesting::Browser.redefine_method(:options) { capabilities }
end
elsif Rails.gem_version < Gem::Version.new("7.1")
Selenium::WebDriver.logger.ignore(:capabilities)
end
Expand All @@ -22,14 +27,12 @@ class ApplicationSystemTestCase < ActionDispatch::SystemTestCase

driven_by :selenium, using: :headless_chrome do |options|
options.add_argument("--disable-dev-shm-usage")
options.add_preference(
:download,
default_directory: "test/dummy/tmp/downloads",
)
options.add_argument("--headless=new")
end

setup do
travel_to Time.zone.local(2020, 1, 9, 9, 41, 44)
page.driver.browser.download_path = "test/dummy/tmp/downloads"
end

teardown do
Expand Down