Consolidate CI gemfiles #458
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We don't have any.
There are no offenses.
Rather than have a gemfile per Ruby version, we can read it in from an environment variable, since it's the only thing that's changing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than have multiple different gemfiles, we can express the logic in a single file that deals with the Rails gems requirements. This would simplify working with gemfiles which actually introduce new gems, as it would reduce the number of files to maintain.
The original motivation for this was introducing a gemfile which added
gem "rails". That may not be required after all, so this was extracted into its own PR.Along the way, some tweaks are made to the RuboCop config.