Revert "Revert all changes to main from v1.4.0" #428
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Is it possible to wait on this until we release 1.5 with #81 ? @sambostock |
Member
Author
|
Of course, I won't merge this then, do it once you're ready! |
Member
Author
|
Hey I just noticed this was never merged. These were the changes I had reverted: v1.4.0...bd21ef6 #367 became #450, however #340 was not reapplied. Here's a cherry-pick: #520 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 73fc625, reversing changes made to bd21ef6.
Following up on #427, this restores main to the state it was before + the changes from that branch compared to v1.4.1.
v1.4.1 was published, created a release for it too, with only the changes from that branch.
Compared to before #427 was merged: bd21ef6...036a514