Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related: #196
This is an initial draft for Fabric support. I have hit a couple of issues we'll need to resolve, some of them are not a flash-list issue specifically:
@react-navigation/stackseems not to be compatible with Fabric (I get the same error as here)@react-navigation/native-stackwhich seems to work and is not an issue (fixture-specific only)AutoLayoutViewsubviewsFlashListPerformanceViewis not migrated to FabriconBlankAreaEventis currently not called in Fabricreanimatedto v3recyclerlistview(possibly some assumption is no longer valid on the new arch)Minor issues (don't need to be resolved):
Resolved issues:
USE_FABRIC=1 RCT_NEW_ARCH_ENABLED=1 bundle exec pod install) in react_native_pods turned on Fabric must havemodular_headers: truewhen using Swift codeReact-RCTFabricandReact-Coreconflictreact-nativedirectly (it seems Swift support has not been properly tested)reanimateddoes not support Fabric which causes issues for our fixture app (Reminders example). It should be ready along with 0.69 release ofreact-nativeUpdate: It does now 🎉I will continue working on those we can tackle and create appropriate issues or PRs (if possible) for those that are outside are repos.
Resources used during the migration:
react-native-gesture-handler. The great thing here is that the library support both Fabric and Paper whereas the official documentation assumes you will want to support Fabric only.Reviewers’ hat-rack 🎩
Screenshots or videos (if needed)
Checklist