Skip to content

Fix stale reference to onScroll and onLoad #1112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 22, 2024
Merged

Fix stale reference to onScroll and onLoad #1112

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,8 @@ and adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.html).

- Update internal dependency and fixture app to `[email protected]`.
- https://github.com/Shopify/flash-list/pull/1076
- Fix stale reference to onScroll and onLoad
- https://github.com/Shopify/flash-list/pull/1112

## [1.6.4] - 2024-03-18

Expand Down
7 changes: 5 additions & 2 deletions src/MasonryFlashList.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,6 +114,9 @@ const MasonryFlashListComponent = React.forwardRef(

const totalColumnFlex = useTotalColumnFlex(dataSet, props);

const propsRef = useRef(props);
propsRef.current = props;

const onScrollRef = useRef<OnScrollCallback[]>([]);
const emptyScrollEvent = useRef(getEmptyScrollEvent())
.current as NativeSyntheticEvent<MasonryFlashListScrollEvent>;
Expand All @@ -135,7 +138,7 @@ const MasonryFlashListComponent = React.forwardRef(
onScrollCallback?.(emptyScrollEvent);
});
if (!scrollEvent.nativeEvent.doNotPropagate) {
props.onScroll?.(scrollEvent);
propsRef.current.onScroll?.(scrollEvent);
}
}
).current;
Expand All @@ -151,7 +154,7 @@ const MasonryFlashListComponent = React.forwardRef(
onScrollProxy?.(emptyScrollEvent);
emptyScrollEvent.nativeEvent.doNotPropagate = false;
}, 32);
props.onLoad?.(args);
propsRef.current.onLoad?.(args);
}).current;

const [parentFlashList, getFlashList] =
Expand Down