Allow mix of single objects and enumerables in valueset#340
Allow mix of single objects and enumerables in valueset#340Shazwazza merged 4 commits intoShazwazza:release/4.0from
Conversation
|
I like the idea. Are you able to add a unit test for this and/or integration tests in the LuceneIndexTests? |
Sure - let me take a look at it today. |
|
@andrewmckaskill This PR currently has merge conflicts could I get you to rebase or merge |
|
@nikcio No it was just a simple conflict in the import statements. I've gone ahead and rebased on top of current release/4.0 branch for you to make the history clean. The only change in this PR is the extra logic inside the |
db2fadb to
b31fe58
Compare
This change updates the yield helper method that converts an
IDictionary<string, object>to anIDictionary<string, IEnumerable<object>>.This allows for greater flexibility when constructing valueSets. Currently, if you have a single field that requires multiple values (say for faceting), you must use the
IDictionary<string, IEnumerable<object>>overload and wrap all your fields in arrays or other enumerable structures. This change means that you can submit an array for a field and it will be automatically interpreted correctly.Before - with all other fields wrapped in arrays:
After - with mix of single objects and arrays: