Games feed now only shows games with at least 1 linked video, new Games Banner and "Sort by" option

[dammitjeff]

No description provided.

[dammitjeff]

• Added new Hero Banner for Games Page: GameVideosHeader
Will use a secondary Hero image pulled from SteamGridDB to make each page feel a little more unique.


• Also added a reworked "sort-by" dropdown with better wording. Newest/Oldest is currently not functional, but building the foundation for the next (hopefully) big feature addition...Automatic dates from file names :)
• Reword Games.js to only show games with at least 1 linked video.

[ShaneIsrael]

I do like the banner but I have a couple of questions before I merge.

1. I see there is a date section "unknown date", is this configurable or is it always on? I like the idea but only if it can be turned off so that you don't end up with many rows with only a single video because they are organized by date.

2. The select for the order in which videos are sorted looks a little weird floating over the banner. Might be worth putting it at the top to the right of the search field since their is plenty of horizontal room. It just feels super out of place on the banner.

Overall though, looks good!

[dammitjeff]

Good questions!

1. I should clarify, currently there is no dates included in this PR, this was a bit of an older screenshot haha. BUT the next PR with proper date function will have a toggle for showing/hiding dates :) Because yes I agree, not everyone will want to have dates visible. That said, I do think it'd be nice if we'd still implement storing that info anyways, even if just in the database, so people can still search by date or check when a clip was recorded. Maybe we can add an info button in the VideoModal, similar to Google Photos:

2. Sure thing, dang I really like that idea of placing it in the search bar, didn't think of that. Let me move the placement before we merge :)

[ShaneIsrael]

I'm totally fine with adding additional info to the database if it makes sorting easier. Having more info about a video stores gives more options.

And yeah, controls I definitely need to improve the location of. I think that top search bar area would be a good spot for it to keep it clean. Give it some proper padding and some vertical center so that its not right up against the search field or bounds.

[dammitjeff]

Done

The sort-by menu is rendered within GameVideos but used a portal to place it in navbar20. That way it remains page specific, without affecting the placement for other pages :)

[ShaneIsrael]

Nice, that looks a lot better and definitely flows better being there I think.