Games tab now accessible to guest users, disabled input while selecting game

[dammitjeff]

• When a user selects a game to assign to a video clip, the search input will be disabled, and a loading icon will be displayed while assets are being downloaded in the background. This is to give the user input feedback, while also preventing the user from changing the result while assets are being downloaded.

• Games Tab now reflects the visibility of video clips. Users that are not signed in will only see game buttons for clips they have public access to.

• Fixed Undefined views bug for videos shown in the games tab.

• Users who have a steamgriddb api key set will no longer see a warning to submit their api key.

•Previously when adding a game, api would pull assets from SteamgridDB and call them everytime to load the game artwork. Api will now pull game assets, download them locally, and organize them into folders in Data/game_assets/ named their corresponding steamgriddb id.

Disclosure, Claude was used to create some of this code, but was reviewed by a real human.

[ShaneIsrael]

@dammitjeff This looks great. Love the addition of the game_assets folder so that we can save those images locally and not have to pull them every time.

Will test on the develop build and if all looks good I should have a production build kicked off this afternoon.

[ShaneIsrael]

Okay I believe there is just 1 minor issue.

In the event that the database already has a link but there is no local asset, you get a 404. So for example, in my case since I already linked games prior in the last develop build it doesn't have the local assets and there's no way for me to clear the game link from the database.

You can check out what I mean on https://v.fireshare.net

So I think we can handle this in a couple ways.

1. if the asset doesn't exist, but there is an entry in the database, it should retry downloading the steamgriddb assets. Maybe via a startup process check.
2. some way for an admin to clear/remove a game category completely (which would require unlinking any linked videos to that category) I did try unlinking all videos from a category but the category was still there, so maybe this is something that should exist anyways that if the last video in a category is unlinked, the category itself gets removed.
3. Some way for the admin to manually kick of an asset fetch for categories that may be missing assets.

Thoughts?

[ShaneIsrael]

[dammitjeff]

1. Hey! Yeah I did run into that issue as well, as no one has the old database just yet im hoping its a non-issue, but you're right that we should implement a failsafe to pull and download images again, if we hit a 404 error. I'll handle that :)

2. I've also been working on that, actually! A sort of edit button that lets you delete games you're not interested in. code is a mess right now though haha.
   If you have any suggestions on what else this "edit" menu could be used for, I can try and implement it.

3. I agree, I was thinking we could repurpose the "scan library" button in the settings to do that? It would find any empty games that don't have any assets, and download them manually. Or we could make a new button entirely, call it "redownload broken cover art" or something.

By the way, with all of these additions, the groundwork is being laid down to be able to search file names, and suggest links to games on the fly. I've been working on it, it's still a work in progress , but, we should be good for a basic "auto link clip to game based on file name" function pretty soon. Trying to implement it so nothing can be categorized without user approval first.

[ShaneIsrael]

I'd like to keep the "Scan Library" as it is since that process can take a while so I'd hate to force someone to kick off that process just to re-download assets. A new button for the asset download would probably be best. Maybe a "Refetch Steamgrid Assets" or something.

The way you have the edit for categories I think is solid. Though as I am a little bit OCD on the UI stuff I think what you have is solid.

But some minor feedback. The icon button height should match the delete button to the right.

And then on the confirmation modal. This toggle button should have some right padding between it and the text.

By the way, with all of these additions, the groundwork is being laid down to be able to search file names, and suggest links to games on the fly. I've been working on it, it's still a work in progress , but, we should be good for a basic "auto link clip to game based on file name" function pretty soon. Trying to implement it so nothing can be categorized without user approval first.

That's awesome, and honestly will probably be my favorite part of this whole feature you've built. Just letting it automagically figure out the categories on first scan in will be huge for someone like myself who just likes to have everything automated haha.