-
Notifications
You must be signed in to change notification settings - Fork 2
Add AMDC article using Simulink Autogen #148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Updated the document to focus on Simulink automatic code generation for AMDC, including calibration methods, procedures, and integration with AMDC.
Updated the steps for creating and configuring a Simulink model, including detailed instructions for setting up a reference model and generating C-code.
|
Hello Dr @noguchi-takahiro. I made a report as much as I can so far, and I need some help from you. Additionally, originally I put all the screenshots for each step but I think it is not necessary. It just makes the article be complicated. Therefore, I removed them and put the most important Simulink block figures. If you agree with this, I can delete the unnecessary image files that are unused. Lastly, we haven't done |
|
Thank you @Daehoon-Sung sensei. Sounds good. |
noguchi-takahiro
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @Daehoon-Sung. I edited the article and removed the images not used for now. We can restore them anytime.
@elsevers I wonder if you can quickly check this article (PDF rendering version: Simulink Automatic Code Generation for AMDC.pdf) to see if we are on the right track? We tried to make the article as simple as possible, while user can follow the Autogen technique. Meanwhile, I am also thinking to show the result after incorporating it with AMDC implementation in the Result section. If you agree, we will work on this soon.
|
Thanks @Daehoon-Sung and @noguchi-takahiro. I took a look through the PDF you kindly attached for me and have left you some minor corrections as annotations here: Simulink.Automatic.Code.Generation.for.AMDC-ELS-2025-12-30.pdf I have a big picture comment though: this document is written as a tutorial and doesn't really fit the "Control with AMDC" section. Upon thinking about this, let's split this into two items:
1. Control with AMDC ArticleItem 1 should focus on explaining the theory and approach of what we are doing with Simulink + AMDC, and not be a set of steps for the user to follow. Take a close look at the structure of the Current Sensor Calibration article and the still-in-progress Encoder article. This document should contain items like the following:
Am I missing anything? 2. TutorialI think Item 2 (tutorial) should reference the "Control with AMDC Article" and then proceed to guide us through steps of starting from scratch to create an AMDC app that uses auto-gen code. The steps should have us create a new Simulink model, configure it properly (following the guidelines of the "Control with AMDC" article, autogen code, place all files in the correct location of our repo, show how to link it up into an app. Think about what the example should be. Maybe replacing the C code in the VSI app with auto gen code to calc the duty ratios? (could point out to the user that they can later replace this with a motor current regulator) Or something else? |
|
Thank you @elsevers. I agree that the current article is not exactly the article, but tutorial. This means that we can keep the current article here as a tutorial (while modify slightly, i.e., follow an example of tutorial article), and create a new article as "Control with AMDC Article", which will be tracked through this issue. @noguchi-takahiro will guide @Daehoon-Sung further on the following item:
@elsevers probably we can replace the following code from this tutorial using Simulink Autogen code, i.e., calculate theta, duty_a, duty_b, and duty_c using Simulink:
What do you think? |

This PR is to close #143
Notes
This PR is to include a procedure how users can implement the Autogen.
Self-Review
In this section, please self-review (answer all questions) on a suitable review checklist prior to requesting review from others. Select a review checklist based on what content is being merged in; see the Review Checklists section.
Reviewer Instructions
Reviewers, please copy and paste a suitable review checklist into your review and answer all questions.
Appendix
This section should be the same for all PRs. Do not edit this section when creating a PR.
Review Checklists
Checklists maintained by the eLev lab for research repositories include:
Standard checklist