Skip to content

Conversation

@next-sentence
Copy link

fix #106

@loevgaard
Copy link
Member

Just to confirm: The intention of this PR is that if I create a redirect from /old to /new and a user lands on /old?param=value then I would be redirected to /new?param=value if I have set keepQueryString to true?

@next-sentence
Copy link
Author

Just to confirm: The intention of this PR is that if I create a redirect from /old to /new and a user lands on /old?param=value then I would be redirected to /new?param=value if I have set keepQueryString to true?

Exactly

@loevgaard
Copy link
Member

Could you also add a screenshot of the 'Create redirect page'?

@next-sentence
Copy link
Author

Screenshot 2023-03-16 at 14 43 04

@loevgaard
Copy link
Member

Can you rebase this PR?

@codecov
Copy link

codecov bot commented Mar 17, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.11 ⚠️

Comparison is base (6bf037e) 5.24% compared to head (806f91d) 5.13%.

❗ Current head 806f91d differs from pull request most recent head 665aec7. Consider uploading reports for the commit 665aec7 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##             master    #107      +/-   ##
===========================================
- Coverage      5.24%   5.13%   -0.11%     
- Complexity      154     158       +4     
===========================================
  Files            28      29       +1     
  Lines           477     487      +10     
===========================================
  Hits             25      25              
- Misses          452     462      +10     
Impacted Files Coverage Δ
src/EventListener/ControllerSubscriber.php 0.00% <0.00%> (ø)
src/EventListener/NotFoundSubscriber.php 0.00% <0.00%> (ø)
src/EventListener/RedirectResponseTrait.php 0.00% <0.00%> (ø)
src/Form/Type/RedirectType.php 0.00% <0.00%> (ø)
src/Model/Redirect.php 8.88% <0.00%> (-0.87%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@loevgaard
Copy link
Member

Could you fix build issues? :)

Petru Binzari added 2 commits March 17, 2023 16:46
@next-sentence
Copy link
Author

@loevgaard Is anything else I can do here?

@loevgaard
Copy link
Member

Argh, stupid svg sanitize

@loevgaard
Copy link
Member

Could you do me a favor and remove roave/security-advisories from require-dev

@loevgaard loevgaard merged commit 5ebfe61 into Setono:master Mar 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

keep query params when redirecting

3 participants