ID3v2: Turn Frame into an enum
#390
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a major change to
Framethat merges the header contents into the frame type itself (ex.TextInformationFramenow holds itsFrameIdandFrameFlags). Previously,Framewas defined as:Meaning that a comment would be stored as:
This design required us to then check both the
valueandid. So, if we wanted to find all comments we would have to do:With
Framenow being an enum, each frame type is responsible for its ID and flags, meaning we can hide away the ID for frames that are well known:And, we can easily find all comments without having to check IDs anymore:
For frames that need an ID specified, like
TextInformationFrame, it is just specified in its constructor: