WindowServer: Make overlay rect shadow customizable in themes #26171
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
👀 pr-needs-review
bplaat
force-pushed
the
overlay-custimization
branch
from
c63b872 to
67fa620
Compare
Contributor
|
Re last commit: Given #26165, does the command palette need something like that too? Or is it fine as is? Can you say in the last commit's commit description why you're making that change? Otherwise, looks good, thanks! |
Member
Author
That already used the correct Window frame style: https://github.com/SerenityOS/serenity/blob/master/Userland/Libraries/LibGUI/CommandPalette.cpp#L188 |
The EmojiInputDialogWidget currently has no frame style, so on themes with no window shadow it looks out of place. The similar CommandPalette dialog uses the Window frame style like normal windows. With this style the Emoji dialog looks more uniform and is more distinct from the background with a window shadow.
bplaat
force-pushed
the
overlay-custimization
branch
from
67fa620 to
a624289
Compare
github-actions
bot
removed
the
👀 pr-needs-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When you resize a window or go to another workspace you see a small overlay window, currently this overlay window always uses a
shadow.pngthat is the fixed for all themes. But this window with a shadow seems out of place on themes without shadows for exampleRedmond. With this pr I have move the path to theoverlay-rect-shadow.pngto the themes.inifiles. When no overlay shadow is defined the default window border will be used with a black background. This is needed because all the current overlays use white text and expect a dark background.There was also a small style bug where the Emoji Input window didn't have a window frame style like all other popup windows.
Demo video
overlays.mp4