[Label] Basic background label definitions #6582
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* The `@basicBackground` variable is set to `none @white`, which is meant to be used in the `background` CSS property of elements. Labels use the variable in `background-color` though, which creates an invalid rule. Switch to use `background` instead.
|
Duplicate of #6440 |
This comment was marked as spam.
This comment was marked as spam.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
@basicBackgroundvariable is set tonone @white, which is meant to be used in thebackgroundCSS property of elements. Labels use the variable inbackground-colorthough, which creates an invalid rule. Switch to usebackgroundinstead.Testcase
[Show before with this fiddle]
https://jsfiddle.net/5xyzedp0/1/