[CDN] cdnjs provides some files from version 1 for version 2, even though they don’t exist in 2

[aguyinmontreal]

I'm currently using version 2.2.12 and the standalone CSS video component in the video.css seem to be different than the one in the the full semantic.css file.

I didn't make a full diff check, however, for example, I can see that the .ui.embed block is missing, and the version seem to be stuck to 2.0.0.

It looks like this issue is affecting multiple files and for multiple versions from 2.0.0 to 2.3.3: colorize.js, colorize.min.js, video.css, video.min.css, video.js, video.min.js, visit.js and visit.min.js.

example: https://cdnjs.cloudflare.com/ajax/libs/semantic-ui/2.2.12/components/video.css

[awgv]

Apparently, we still have video component in the dist of master, and I think that’s why cdnjs grabs it, not sure why colorize/visit are available for 2.3.3, because both don’t exist in cdnjs for 2.3.3.

[aguyinmontreal]

@Banandrew
My big question is: Why the video component different in the standalone and the semantic.css?

I was scratching my head for a few days wondering why in hell my production and development css looked different when I found this.

I think the video/colorize/visit files should be removed/replaced for all versions since 2.0.0, not only for 2.3.3.

[ColinFrick]

@aguyinmontreal There is no video component in SUI2, there is the embed module for videos: https://semantic-ui.com/modules/embed.html

[aguyinmontreal]

@Banandrew @ColinFrick

I understand you both say that there should not be a video component in SUI2. However, whether you like it or not, there is a video component in all full semantic.css and semantic.min.css files from version 2.0.0 to version 2.3.3.

Here are some examples:

• For version 2.3.3, it starts at line 33418 (starts with a .ui.embed block)
• For version 2.2.12, it starts at line 30822 (starts with a .ui.embed block)
• For version 2.2.1, it starts at line 30515 (starts with a .ui.embed block)

What is more strange is that these video components are different than the ones found in the standalone video.css and video.min.css files.

Here are some examples:

• For version 2.3.3, it starts with a .ui.video block
• For version 2.2.12, it starts with a .ui.video block
• For version 2.2.1, it starts with a .ui.video block

And this is only for css, I didn't check js files.

[ColinFrick]

Yes seems like the header is wrong, that is the embed module: https://cdnjs.cloudflare.com/ajax/libs/semantic-ui/2.3.3/components/embed.css

[aguyinmontreal]

@Banandrew
colorize/visit standalone seem no longer distributed in 2.3.3, however it was from 2.0.0 to 2.3.0

[aguyinmontreal]

@ColinFrick ok, thanks

[awgv]

@aguyinmontreal My bad, I was sure I was looking at 2.3.3 when I was typing the message—it doesn’t matter, though, we can’t remove the video component from dist without the maintainer, so we’ll just have to wait. Thanks again for bringing it up!

[Nazariy]

Is it possible to update CDN with most recent version, seems like it's still on version 2.3.3?

[ColinFrick]

@Nazariy there is an open issue for this: cdnjs/cdnjs#12953