Conversation
PR TypeBug fix, Tests Description
|
| Relevant files | |||
|---|---|---|---|
| Bug fix |
| ||
| Tests |
| ||
| Configuration changes |
|
PR Compliance Guide 🔍Below is a summary of compliance checks for this PR:
Compliance status legend🟢 - Fully Compliant🟡 - Partial Compliant 🔴 - Not Compliant ⚪ - Requires Further Human Verification 🏷️ - Compliance label |
|||||||||||||||||||||||||
PR Code Suggestions ✨Explore these optional code suggestions:
|
|||||||||
There was a problem hiding this comment.
Pull request overview
Enables Ruby BiDi unit tests to run under Bazel and fixes an issue in BiDi cookie serialization uncovered by the newly-enabled tests.
Changes:
- Add a Bazel
BUILD.bazelto register/run all*_spec.rbunit tests inrb/spec/unit/selenium/webdriver/bidi. - Fix
Selenium::WebDriver::BiDi::Cookies#as_jsonto return the correct array-of-hashes structure (consistent withHeaders#as_json). - Update the cookies unit spec to assert the corrected serialization output.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| rb/spec/unit/selenium/webdriver/bidi/cookies_spec.rb | Updates unit test expectations to match the corrected cookie JSON-ready structure. |
| rb/spec/unit/selenium/webdriver/bidi/BUILD.bazel | Adds Bazel targets so BiDi unit specs in this directory are executed. |
| rb/lib/selenium/webdriver/bidi/network/cookies.rb | Fixes as_json to return a proper cookie entry per hash pair without mutating the underlying hash. |
A couple unit test directories didn't have BUILD files, so the tests weren't running
Found bugs
🔗 Related Issues
💥 What does this PR do?
🔄 Types of changes