Skip to content

[py] Fix return type hint for alert_is_present #16975

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cgoldberg merged 3 commits into from
Jan 22, 2026
Merged

[py] Fix return type hint for alert_is_present #16975

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b42582b
[py] Fix return type hint for alert_is_present from 'bool' to 'Litera…
nemowang2003 Jan 21, 2026
64348dd
Merge branch 'trunk' into fix-ec-type-hint
cgoldberg Jan 22, 2026
a0f8069
Fix docstring
cgoldberg Jan 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions py/selenium/webdriver/support/expected_conditions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -692,19 +692,16 @@ def _predicate(driver: WebDriver):
return _predicate


def alert_is_present() -> Callable[[WebDriver], Alert | bool]:
def alert_is_present() -> Callable[[WebDriver], Alert | Literal[False]]:
"""Check that an alert is present and switch to it.

Returns:
The Alert once it is located.
The Alert once it is located, or False if no alert is present.

Example:
from selenium.webdriver.support.ui import WebDriverWait
from selenium.webdriver.support import expected_conditions as EC
alert = WebDriverWait(driver, 10).until(EC.alert_is_present())

Note:
If the alert is present it switches the given driver to it.
"""

def _predicate(driver: WebDriver):
Expand Down