Skip to content

[java][BiDi] change emulation commands return type to void #16699

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
asolntsev merged 1 commit into from
Dec 7, 2025
Merged

[java][BiDi] change emulation commands return type to void #16699

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 6 additions & 7 deletions java/src/org/openqa/selenium/bidi/emulation/Emulation.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,23 +37,22 @@ public Emulation(WebDriver driver) {
this.bidi = ((HasBiDi) driver).getBiDi();
}

public Map<String, Object> setGeolocationOverride(SetGeolocationOverrideParameters parameters) {
public void setGeolocationOverride(SetGeolocationOverrideParameters parameters) {
Require.nonNull("SetGeolocationOverride parameters", parameters);

return bidi.send(
new Command<>("emulation.setGeolocationOverride", parameters.toMap(), Map.class));
bidi.send(new Command<>("emulation.setGeolocationOverride", parameters.toMap(), Map.class));
}

public Map<String, Object> setTimezoneOverride(SetTimezoneOverrideParameters parameters) {
public void setTimezoneOverride(SetTimezoneOverrideParameters parameters) {
Require.nonNull("SetTimezoneOverride parameters", parameters);

return bidi.send(new Command<>("emulation.setTimezoneOverride", parameters.toMap(), Map.class));
bidi.send(new Command<>("emulation.setTimezoneOverride", parameters.toMap(), Map.class));
}

public Map<String, Object> setScriptingEnabled(SetScriptingEnabledParameters parameters) {
public void setScriptingEnabled(SetScriptingEnabledParameters parameters) {
Require.nonNull("SetScriptingEnabled parameters", parameters);

return bidi.send(new Command<>("emulation.setScriptingEnabled", parameters.toMap(), Map.class));
bidi.send(new Command<>("emulation.setScriptingEnabled", parameters.toMap(), Map.class));
}

public void setUserAgentOverride(SetUserAgentOverrideParameters parameters) {
Expand Down
Loading