[py] Re-add defaults for Chromium kwargs#16372
Merged
cgoldberg merged 1 commit intoSeleniumHQ:trunkfrom Oct 2, 2025
Merged
Conversation
Contributor
PR Compliance Guide 🔍Below is a summary of compliance checks for this PR:
Compliance status legend🟢 - Fully Compliant🟡 - Partial Compliant 🔴 - Not Compliant ⚪ - Requires Further Human Verification 🏷️ - Compliance label |
||||||||||||||||||
Contributor
PR Code Suggestions ✨Explore these optional code suggestions:
|
|||||||||
Member
Author
|
The only failure in CI is from Java and unrelated to these changes. |
This was referenced Oct 19, 2025
This was referenced Dec 15, 2025
This was referenced Jan 19, 2026
This was referenced Feb 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User description
🔗 Related Issues
#16309
💥 What does this PR do?
This PR fixes a breaking change to the Chromium class
__init__signature inadvertently introduced in #16309. Defaults ofNoneare re-added back as keyword argument defaults forbrowser_nameandvendor_prefix.🔄 Types of changes
PR Type
Bug fix
Description
Re-add
Nonedefaults forbrowser_nameandvendor_prefixparametersFix breaking change in ChromiumDriver
__init__signatureRestore backwards compatibility for Chromium class initialization
Diagram Walkthrough
File Walkthrough
webdriver.py
Restore default parameter values in ChromiumDriver constructorpy/selenium/webdriver/chromium/webdriver.py
browser_nameparameter from requiredstrto optional withNonedefault
vendor_prefixparameter from requiredstrto optional withNonedefaultOptionaltype hints for both parameters