You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
for some reason your branch failed when building the docs.. I can't see anything you changed that would cause that. I just merged trunk into your branch to run CI again.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User description
🔗 Related Issues
💥 What does this PR do?
Use typed string for LogLevel which matches the rest bindings
🔧 Implementation Notes
💡 Additional Considerations
🔄 Types of changes
PR Type
Enhancement, Tests
Description
Introduced
LogLevelconstants for BiDi log levelsUpdated tests to use
LogLevelconstantsImproved consistency with other Selenium bindings
Changes walkthrough 📝
log.py
Add LogLevel constants for BiDi loggingpy/selenium/webdriver/common/bidi/log.py
LogLevelclass with log level constantsbidi_script_tests.py
Update BiDi log tests to use LogLevel constantspy/test/selenium/webdriver/common/bidi_script_tests.py
LogLevelconstants in assertionsLogLevelusage in tests