[grid] Ignored options when they are prefixed, safari specif as well#15574
[grid] Ignored options when they are prefixed, safari specif as well#15574
Conversation
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨Explore these optional code suggestions:
|
|||||||||
CI Feedback 🧐(Feedback updated until commit a2057a8)A test triggered by this PR failed. Here is an AI-generated analysis of the failure:
|
User description
🔗 Related Issues
Fixes #15481
Fixes #14485
💥 What does this PR do?
This will ignore any prefixed
optionscapability in theDefaultSlotMatcher. This was wrongly considered during the matching process, and it should not be. It needs to be passed along so the remote end deals with it.🔧 Implementation Notes
This resolves the core problem of the linked issues. It is true that
optionsshould not be handled as they are.💡 Additional Considerations
No.
🔄 Types of changes
PR Type
Bug fix, Tests
Description
Added "safari:" to ignored extension capability prefixes in
DefaultSlotMatcher.Excluded "options" capabilities from matching in
DefaultSlotMatcher.Introduced a new test to verify "options" capabilities are ignored for matching.
Changes walkthrough 📝
DefaultSlotMatcher.java
Update DefaultSlotMatcher to ignore specific capabilitiesjava/src/org/openqa/selenium/grid/data/DefaultSlotMatcher.java
DefaultSlotMatcherTest.java
Add test for ignoring "options" capabilities in matchingjava/test/org/openqa/selenium/grid/data/DefaultSlotMatcherTest.java
matching.