[JS] Add websocket port option in Firefox ServiceBuilder when '--connect-existing' is not passed#15557
Conversation
…ect-existing' is not passed
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨Explore these optional code suggestions:
|
||||||||||||
CI Feedback 🧐(Feedback updated until commit 4f8488c)A test triggered by this PR failed. Here is an AI-generated analysis of the failure:
|
harsha509
left a comment
There was a problem hiding this comment.
LGTM!
Test failures are not related to the changes in this PR.
User description
Fixes #15451
🔗 Related Issues
💥 What does this PR do?
🔧 Implementation Notes
💡 Additional Considerations
🔄 Types of changes
PR Type
Bug fix, Enhancement
Description
Added support for
--websocket-portargument in Firefox ServiceBuilder.Ensured the websocket port is only added when
--connect-existingis not passed.Integrated logic to dynamically find free ports for both service and websocket.
Changes walkthrough 📝
firefox.js
Added websocket port logic in Firefox ServiceBuilderjavascript/selenium-webdriver/firefox.js
findFreePortfor dynamic port allocation.ServiceBuilderto include--websocket-portargument.--websocket-portis added only when--connect-existingisabsent.
build()method to handle dynamic port assignment for bothservice and websocket.