You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The toMap() method creates a new Map instance for each condition, which could lead to inconsistent behavior. Consider using a mutable map builder pattern for better maintainability.
✅ Optimize map creation efficiencySuggestion Impact:The commit directly implements the suggestion by replacing Map.of() calls with a single mutable HashMap and using put() operations
Why: The suggestion improves code efficiency by replacing immutable Map.of() calls with a single mutable HashMap, reducing object creation overhead and making the code more maintainable. While valid, this is a minor optimization with moderate impact.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User description
Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it
Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.
Description
This PR adds the bidi method
setCacheBehaviordefined in the bidi specs - https://w3c.github.io/webdriver-bidi/#command-network-setCacheBehavior.I have verified that this works with the latest stable Firefox 134 and Chrome 132.
Motivation and Context
Types of changes
Checklist
PR Type
Enhancement, Tests
Description
Implemented the BiDi
setCacheBehaviormethod for Java bindings.Added
CacheBehaviorenum andSetCacheBehaviorParametersclass.Developed unit tests for
setCacheBehaviorfunctionality.Enhanced network module to support cache behavior configuration.
Changes walkthrough 📝
Network.java
Add `setCacheBehavior` method to Network modulejava/src/org/openqa/selenium/bidi/module/Network.java
setCacheBehaviormethod to theNetworkclass.SetCacheBehaviorParametersfor cache behaviorconfiguration.
CacheBehavior.java
Introduce `CacheBehavior` enum for cache settingsjava/src/org/openqa/selenium/bidi/network/CacheBehavior.java
CacheBehaviorenum to define cache behavior options.DEFAULTandBYPASScache behavior types.SetCacheBehaviorParameters.java
Add `SetCacheBehaviorParameters` for cache configurationjava/src/org/openqa/selenium/bidi/network/SetCacheBehaviorParameters.java
SetCacheBehaviorParametersclass for cache behaviorconfiguration.
toMapmethod for parameter serialization.NetworkCommandsTest.java
Add tests for `setCacheBehavior` in Network modulejava/test/org/openqa/selenium/bidi/network/NetworkCommandsTest.java
setCacheBehaviorfunctionality.BYPASSandDEFAULTcache behaviors with and without contextIDs.