You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Thanks for contributing to Selenium! A PR well described will help maintainers to quickly review and merge it
Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.
Description
Addresses CLS compliance and obsoletion warnings with ActionSequence.inputDevice
Motivation and Context
Having two members whose names differ only by case is not CLS-compliant, since some .NET languages are not case-sensitive. As such, we can mark the obsolete property as incompatible with CLS.
Likewise, we can replace usage of this property with the non-obsolete version.
Types of changes
Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)
Here are some key observations to aid the review process:
⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ Recommended focus areas for review
Code Consistency Verify that replacing the obsolete inputDevice property with InputDevice maintains the same behavior and doesn't introduce any regressions
Follow standard naming conventions for public properties in C#
The property should follow C# naming conventions by using PascalCase for public members. Since this is an obsolete property redirecting to InputDevice, it should maintain consistent casing.
Why: The suggestion correctly identifies a violation of C# naming conventions where public properties should use PascalCase. This is particularly important for maintaining code consistency, especially since the property redirects to a properly-named 'InputDevice' property.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User description
Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it
Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.
Description
Addresses CLS compliance and obsoletion warnings with
ActionSequence.inputDeviceMotivation and Context
Having two members whose names differ only by case is not CLS-compliant, since some .NET languages are not case-sensitive. As such, we can mark the obsolete property as incompatible with CLS.
Likewise, we can replace usage of this property with the non-obsolete version.
Types of changes
Checklist
PR Type
enhancement, bug fix
Description
[CLSCompliant(false)]attribute to the obsoleteinputDeviceproperty inActionSequence.csto address CLS compliance warnings.inputDeviceproperty with the non-obsoleteInputDeviceproperty inActions.cs.Changes walkthrough 📝
ActionSequence.cs
Add CLS compliance attribute to obsolete propertydotnet/src/webdriver/Interactions/ActionSequence.cs
inputDeviceproperty.inputDeviceas non-CLS compliant.Actions.cs
Replace obsolete property usage with non-obsolete versiondotnet/src/webdriver/Interactions/Actions.cs
inputDevicewithInputDevice.