[dotnet] Add future-proofing note on Base64UrlEncoder#14821
Merged
nvborisenko merged 3 commits intoSeleniumHQ:trunkfrom Nov 27, 2024
Merged
[dotnet] Add future-proofing note on Base64UrlEncoder#14821nvborisenko merged 3 commits intoSeleniumHQ:trunkfrom
Base64UrlEncoder#14821nvborisenko merged 3 commits intoSeleniumHQ:trunkfrom
Conversation
Contributor
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
Contributor
Author
|
Should this type be internal? |
Contributor
PR Code Suggestions ✨No code suggestions found for the PR. |
nvborisenko
reviewed
Nov 27, 2024
Member
|
We kept origin, goal, context. Thank you Michael. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User description
Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it
Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.
Description
Addresses request in #14813
Motivation and Context
This note will help us remember about the
Base64Urltype that is available on .NET 9+Types of changes
Checklist
PR Type
documentation
Description
Base64UrlEncoderclass to improve code safety.Base64Urltype available in .NET 9+, addressing issue [dotnet] [🚀 Feature]: Consider using the newBase64Url#14813.Changes walkthrough 📝
Base64UrlEncoder.cs
Add future-proofing note and enable nullable reference typesdotnet/src/webdriver/Internal/Base64UrlEncoder.cs
Base64Urltype in .NET 9+.