[py] Add backward compatibility for AppiumConnection#14696
Conversation
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨Explore these optional code suggestions:
|
CI Failure Feedback 🧐
|
Signed-off-by: Viet Nguyen Duc <nguyenducviet4496@gmail.com>
88d66a9 to
a79a107
Compare
User description
Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it
Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.
Description
_ca_certsand_timeoutwere moved toClientConfig. However, looks like those are being used in AppiumConnection.Before
AppiumConnectionis implemented on top of4.26.0, adding back those 2 attrs inRemoteConnectionMotivation and Context
Types of changes
Checklist
PR Type
Bug fix
Description
_timeoutand_ca_certsattributes toRemoteConnectionto maintain backward compatibility with AppiumConnection._timeoutis set using theGLOBAL_DEFAULT_TIMEOUTenvironment variable or the default socket timeout._ca_certsis determined by theREQUESTS_CA_BUNDLEenvironment variable or defaults tocertifi.where().__init__method to ensure these attributes are set fromClientConfig.Changes walkthrough 📝
remote_connection.py
Add backward compatibility attributes to RemoteConnectionpy/selenium/webdriver/remote/remote_connection.py
_timeoutand_ca_certsattributes toRemoteConnectionforbackward compatibility.
_timeoutand_ca_certsusing environment variables or defaultvalues.
__init__method to assigntimeoutandca_certsfromClientConfig.