Skip to content

[java][bidi] Remove non-relevant annotations #14013

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 22, 2024
Merged

[java][bidi] Remove non-relevant annotations #14013

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c4eb76e
[java][bidi] Remove non-relevant annotations
pujagani May 22, 2024
64ce192
[java] Enable tests working in Chrome and Edge
pujagani May 22, 2024
9a57e4e
[bidi] Disable tests in Edge
pujagani May 22, 2024
9c1d651
[java] Add missing import
pujagani May 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions java/test/org/openqa/selenium/bidi/BiDiSessionTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,19 +18,14 @@
package org.openqa.selenium.bidi;

import static org.assertj.core.api.AssertionsForClassTypes.assertThat;
import static org.openqa.selenium.testing.drivers.Browser.IE;
import static org.openqa.selenium.testing.drivers.Browser.SAFARI;

import java.util.Collections;
import org.junit.jupiter.api.Test;
import org.openqa.selenium.testing.JupiterTestBase;
import org.openqa.selenium.testing.NotYetImplemented;

class BiDiSessionTest extends JupiterTestBase {

@Test
@NotYetImplemented(SAFARI)
@NotYetImplemented(IE)
void shouldBeAbleToCreateABiDiSession() {
BiDi biDi = ((HasBiDi) driver).getBiDi();

Expand Down
4 changes: 0 additions & 4 deletions java/test/org/openqa/selenium/bidi/BiDiTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,6 @@
import static org.assertj.core.api.AssertionsForClassTypes.assertThat;
import static org.openqa.selenium.testing.Safely.safelyCall;
import static org.openqa.selenium.testing.drivers.Browser.EDGE;
import static org.openqa.selenium.testing.drivers.Browser.IE;
import static org.openqa.selenium.testing.drivers.Browser.SAFARI;

import java.util.concurrent.CompletableFuture;
import java.util.concurrent.ExecutionException;
Expand Down Expand Up @@ -54,8 +52,6 @@ public void setUp() {
}

@Test
@NotYetImplemented(SAFARI)
@NotYetImplemented(IE)
@NotYetImplemented(EDGE)
void canNavigateAndListenToErrors()
throws ExecutionException, InterruptedException, TimeoutException {
Expand Down
7 changes: 0 additions & 7 deletions java/test/org/openqa/selenium/bidi/browser/BrowserCommandsTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,6 @@
import org.openqa.selenium.environment.webserver.AppServer;
import org.openqa.selenium.environment.webserver.NettyAppServer;
import org.openqa.selenium.testing.JupiterTestBase;
import org.openqa.selenium.testing.NotYetImplemented;

class BrowserCommandsTest extends JupiterTestBase {

Expand All @@ -44,8 +43,6 @@ public void setUp() {
}

@Test
@NotYetImplemented(SAFARI)
@NotYetImplemented(IE)
void canCreateAUserContext() {
String userContext = browser.createUserContext();

Expand All @@ -55,8 +52,6 @@ void canCreateAUserContext() {
}

@Test
@NotYetImplemented(SAFARI)
@NotYetImplemented(IE)
void canGetUserContexts() {
String userContext1 = browser.createUserContext();
String userContext2 = browser.createUserContext();
Expand All @@ -69,8 +64,6 @@ void canGetUserContexts() {
}

@Test
@NotYetImplemented(SAFARI)
@NotYetImplemented(IE)
void canRemoveUserContext() {
String userContext1 = browser.createUserContext();
String userContext2 = browser.createUserContext();
Expand Down
18 changes: 0 additions & 18 deletions java/test/org/openqa/selenium/bidi/browsingcontext/BrowsingContextInspectorTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,8 +47,6 @@ public void setUp() {
}

@Test
@NotYetImplemented(SAFARI)
@NotYetImplemented(IE)
void canListenToWindowBrowsingContextCreatedEvent()
throws ExecutionException, InterruptedException, TimeoutException {
try (BrowsingContextInspector inspector = new BrowsingContextInspector(driver)) {
Expand All @@ -69,8 +67,6 @@ void canListenToWindowBrowsingContextCreatedEvent()
}

@Test
@NotYetImplemented(SAFARI)
@NotYetImplemented(IE)
void canListenToBrowsingContextDestroyedEvent()
throws ExecutionException, InterruptedException, TimeoutException {
try (BrowsingContextInspector inspector = new BrowsingContextInspector(driver)) {
Expand All @@ -92,8 +88,6 @@ void canListenToBrowsingContextDestroyedEvent()
}

@Test
@NotYetImplemented(SAFARI)
@NotYetImplemented(IE)
void canListenToTabBrowsingContextCreatedEvent()
throws ExecutionException, InterruptedException, TimeoutException {
try (BrowsingContextInspector inspector = new BrowsingContextInspector(driver)) {
Expand All @@ -113,8 +107,6 @@ void canListenToTabBrowsingContextCreatedEvent()
}

@Test
@NotYetImplemented(SAFARI)
@NotYetImplemented(IE)
void canListenToDomContentLoadedEvent()
throws ExecutionException, InterruptedException, TimeoutException {
try (BrowsingContextInspector inspector = new BrowsingContextInspector(driver)) {
Expand All @@ -131,8 +123,6 @@ void canListenToDomContentLoadedEvent()
}

@Test
@NotYetImplemented(SAFARI)
@NotYetImplemented(IE)
void canListenToBrowsingContextLoadedEvent()
throws ExecutionException, InterruptedException, TimeoutException {
try (BrowsingContextInspector inspector = new BrowsingContextInspector(driver)) {
Expand All @@ -149,8 +139,6 @@ void canListenToBrowsingContextLoadedEvent()
}

@Test
@NotYetImplemented(SAFARI)
@NotYetImplemented(IE)
@NotYetImplemented(CHROME)
@NotYetImplemented(EDGE)
void canListenToNavigationStartedEvent()
Expand All @@ -169,8 +157,6 @@ void canListenToNavigationStartedEvent()
}

@Test
@NotYetImplemented(SAFARI)
@NotYetImplemented(IE)
void canListenToFragmentNavigatedEvent()
throws ExecutionException, InterruptedException, TimeoutException {
try (BrowsingContextInspector inspector = new BrowsingContextInspector(driver)) {
Expand All @@ -191,8 +177,6 @@ void canListenToFragmentNavigatedEvent()
}

@Test
@NotYetImplemented(SAFARI)
@NotYetImplemented(IE)
void canListenToUserPromptOpenedEvent()
throws ExecutionException, InterruptedException, TimeoutException {
try (BrowsingContextInspector inspector = new BrowsingContextInspector(driver)) {
Expand All @@ -212,8 +196,6 @@ void canListenToUserPromptOpenedEvent()
}

@Test
@NotYetImplemented(SAFARI)
@NotYetImplemented(IE)
// TODO: This test is flaky for comparing the browsing context id for Chrome and Edge. Fix flaky
// test.
void canListenToUserPromptClosedEvent()
Expand Down
Loading