-
-
Notifications
You must be signed in to change notification settings - Fork 8.6k
[rust] Use DEBUG level for WARN traces in offline mode #13810
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
PR Description updated to latest commit (7c143e1)
|
PR Review
✨ Review tool usage guide:Overview: The tool can be triggered automatically every time a new PR is opened, or can be invoked manually by commenting on any PR.
See the review usage page for a comprehensive guide on using this tool. |
PR Code Suggestions
✨ Improve tool usage guide:Overview:
See the improve usage page for a comprehensive guide on using this tool. |
diemol
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @bonigarcia!
CI Failure Feedback
✨ CI feedback usage guide:The CI feedback tool (
In addition to being automatically triggered, the tool can also be invoked manually by commenting on a PR: where Configuration options
See more information about the |
User description
Description
This PR changes the level of several WARN traces to DEBUG when the offline mode is enabled. Example:
Motivation and Context
Requested in #13809.
Types of changes
Checklist
Type
bug_fix
Description
debug_or_warninlogger.rsto dynamically log messages as either DEBUG or WARN based on the offline mode flag.debug_or_warnmethod inlib.rsandmain.rsto improve logging when the Selenium Manager operates in offline mode, specifically when falling back to using cached browsers or drivers.Changes walkthrough
lib.rs
Use Debug or Warn Level Logging in Offline Moderust/src/lib.rs
debug_or_warnmethod usage for logging when using a browserfrom the cache in offline mode.
logger.rs
Add Debug or Warn Logging Methodrust/src/logger.rs
debug_or_warnto log messages as DEBUG or WARNbased on offline mode flag.
main.rs
Enhance Logging for Driver Cache Usage in Offline Moderust/src/main.rs
debug_or_warnfor logging driver cache usage in offline mode.