Conversation
|
I would prefer using Moreover, then we can include |
|
There is a bazel command for it, too! 😜 It's been added into the format script, so it will fail RBE test like everything else that isn't properly formatted, and the fix, like other things in the project will be to run I'm not opposed to having editorconfig, but someone has to write it. 😄 |
nvborisenko
left a comment
There was a problem hiding this comment.
Go ahead, please don't forget to resolve conflicts and verify newly added files with old copyright notice.
|
Ah, we already have I have added the following there: Works good, but |
# Conflicts: # dotnet/src/webdriver/DevTools/DevToolsExtensionMethods.cs # dotnet/src/webdriver/DevTools/v128/V128Domains.cs # dotnet/src/webdriver/DevTools/v128/V128JavaScript.cs # dotnet/src/webdriver/DevTools/v128/V128Log.cs # dotnet/src/webdriver/DevTools/v128/V128Network.cs # dotnet/src/webdriver/DevTools/v128/V128Target.cs # dotnet/src/webdriver/DevTools/v129/V129Domains.cs # dotnet/src/webdriver/DevTools/v129/V129JavaScript.cs # dotnet/src/webdriver/DevTools/v129/V129Log.cs # dotnet/src/webdriver/DevTools/v129/V129Network.cs # dotnet/src/webdriver/DevTools/v129/V129Target.cs # dotnet/src/webdriver/DevTools/v130/V130Domains.cs # dotnet/src/webdriver/DevTools/v130/V130JavaScript.cs # dotnet/src/webdriver/DevTools/v130/V130Log.cs # dotnet/src/webdriver/DevTools/v130/V130Network.cs # dotnet/src/webdriver/DevTools/v130/V130Target.cs # dotnet/src/webdriver/DriverOptionsMergeResult.cs # dotnet/test/chrome/ChromeSpecificTests.cs # dotnet/test/common/AlertsTest.cs # dotnet/test/common/AssemblyFixture.cs # dotnet/test/common/ClickScrollingTest.cs # dotnet/test/common/ClickTest.cs # dotnet/test/common/CookieImplementationTest.cs # dotnet/test/common/CookieTest.cs # dotnet/test/common/CorrectEventFiringTest.cs # dotnet/test/common/CustomTestAttributes/NeedsFreshDriverAttribute.cs # dotnet/test/common/DevTools/DevToolsConsoleTest.cs # dotnet/test/common/DevTools/DevToolsLogTest.cs # dotnet/test/common/DevTools/DevToolsNetworkTest.cs # dotnet/test/common/DevTools/DevToolsPerformanceTest.cs # dotnet/test/common/DevTools/DevToolsProfilerTest.cs # dotnet/test/common/DevTools/DevToolsSecurityTest.cs # dotnet/test/common/DevTools/DevToolsTargetTest.cs # dotnet/test/common/ElementAttributeTest.cs # dotnet/test/common/ElementFindingTest.cs # dotnet/test/common/ElementPropertyTest.cs # dotnet/test/common/Environment/InlinePage.cs # dotnet/test/common/Environment/TestWebServerConfig.cs # dotnet/test/common/Environment/UrlBuilder.cs # dotnet/test/common/ExecutingAsyncJavascriptTest.cs # dotnet/test/common/ExecutingJavascriptTest.cs # dotnet/test/common/FormHandlingTests.cs # dotnet/test/common/FrameSwitchingTest.cs # dotnet/test/common/GetLogsTest.cs # dotnet/test/common/ImplicitWaitTest.cs # dotnet/test/common/Interactions/ActionBuilderTest.cs # dotnet/test/common/Interactions/BasicMouseInterfaceTest.cs # dotnet/test/common/Interactions/BasicWheelInterfaceTest.cs # dotnet/test/common/Interactions/DragAndDropTest.cs # dotnet/test/common/JavascriptEnabledBrowserTest.cs # dotnet/test/common/NavigationTest.cs # dotnet/test/common/NetworkInterceptionTests.cs # dotnet/test/common/PageLoadingTest.cs # dotnet/test/common/PositionAndSizeTest.cs # dotnet/test/common/ProxySettingTest.cs # dotnet/test/common/ProxyTest.cs # dotnet/test/common/SelectElementHandlingTest.cs # dotnet/test/common/SessionHandlingTest.cs # dotnet/test/common/ShadowRootHandlingTest.cs # dotnet/test/common/SlowLoadingPageTest.cs # dotnet/test/common/StubDriver.cs # dotnet/test/common/SvgElementTest.cs # dotnet/test/common/TakesScreenshotTest.cs # dotnet/test/common/TargetLocatorTest.cs # dotnet/test/common/TextHandlingTest.cs # dotnet/test/common/TypingTest.cs # dotnet/test/common/VirtualAuthn/VirtualAuthenticatorTest.cs # dotnet/test/common/VisibilityTest.cs # dotnet/test/common/WindowSwitchingTest.cs # dotnet/test/common/WindowTest.cs # dotnet/test/edge/AssemblyTeardown.cs # dotnet/test/firefox/AssemblyTeardown.cs # dotnet/test/firefox/FirefoxDriverTest.cs # dotnet/test/firefox/FirefoxProfileTests.cs # dotnet/test/ie/AssemblyTeardown.cs # dotnet/test/remote/AssemblyTeardown.cs # dotnet/test/remote/ChromeRemoteWebDriver.cs # dotnet/test/remote/EdgeRemoteWebDriver.cs # dotnet/test/remote/FirefoxRemoteWebDriver.cs # dotnet/test/remote/RemoteSessionCreationTests.cs # dotnet/test/remote/RemoteWebDriverSpecificTests.cs # dotnet/test/remote/TestInternetExplorerRemoteWebDriver.cs # dotnet/test/support/Events/EventFiringWebDriverTest.cs # dotnet/test/support/Extensions/ExecuteJavaScriptTest.cs # dotnet/test/support/UI/DefaultWaitTest.cs # dotnet/test/support/UI/FakeClock.cs # dotnet/test/support/UI/LoadableComponentTests.cs # dotnet/test/support/UI/PopupWindowFinderTest.cs # dotnet/test/support/UI/SelectBrowserTests.cs # dotnet/test/support/UI/SelectTests.cs # dotnet/test/support/UI/SlowLoadableComponentTest.cs # dotnet/test/support/UI/WebDriverWaitTest.cs
|
Merged the PR based on reviewers approval and CI passed. |

Status
I did not see any files that had other copyright info at the top or anything that should be excluded from these changes.
Description
Motivation and Context
Bring .NET in line with all the other languages