-
-
Notifications
You must be signed in to change notification settings - Fork 8.6k
[py] update SOC for driver finder and selenium manager classes #13387
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files☔ View full report in Codecov by Sentry. |
7420ddc to
563136f
Compare
c7fb05a to
b7d672b
Compare
84cfac8 to
9b6c810
Compare
AutomatedTester
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this looks good enough. I am not sure we need to have the Rakefile stuff as that should all be handled by bazel already
|
Thanks, I would have merged this for 4.17 but I wanted to get .NET happy first as well before merging everything else. 😦 The Python is a good example of this. but actually it is: So I create task that does both and outputs results My plan is to support a wrapper for each language with defaults like: |
Description
Motivation and Context
get_pathtoSeleniumManagerclass #12554Comments