You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Thanks for contributing to the Docker-Selenium project! A PR well described will help maintainers to quickly review and merge it
Before submitting your PR, please check our contributing guidelines, applied for this repository.
Avoid large PRs, help reviewers by making them as simple and short as possible.
Description
Motivation and Context
Types of changes
Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)
The .keda directory, containing documentation and code for a custom KEDA build process, is now obsolete due to the switch to official KEDA images. This directory should be removed to avoid confusion.
In order to deliver and get feedback continuously on any new bug fixes, improvement, or features for the Selenium Grid scaler. We select the latest stable version of KEDA core, patch the scaler implementation then build and deploy KEDA container images following our image tag convention.
The stable implementation will be merged to the upstream KEDA repository frequently and will be available in the next KEDA core release.
# How to use the patched scaler
// .keda/README.md
# Introduction
... we select the latest stable version of KEDA core, patch the scaler implementation then build and deploy KEDA container images...
# How to use the patched scaler
...
```bash
dockerpullghcr.io/kedacore/keda:2.19.0
...
#### After:
```makefile
// The entire .keda/ directory is removed as it is now obsolete.
// Makefile
// Variables related to the custom KEDA build process are removed.
// e.g., KEDA_CORE_VERSION, KEDA_BASED_NAME, KEDA_BASED_TAG
Suggestion importance[1-10]: 9
__
Why: The suggestion correctly identifies that the PR makes the entire .keda directory obsolete by switching to official KEDA images, and leaving this directory with its misleading documentation will cause significant confusion and maintenance overhead.
High
Possible issue
Add organization namespace to image pulls
Update the docker pull commands for keda-metrics-apiserver and keda-admission-webhooks to include the kedacore/ organization namespace.
Why: This suggestion correctly identifies that the docker pull commands for keda-metrics-apiserver and keda-admission-webhooks are missing the kedacore/ organization prefix, which would cause image pull failures.
Medium
General
Use flexible Helm chart versioning
In charts/selenium-grid/Chart.yaml, change the KEDA dependency version from 2.19 to ^2.19.0 to allow for automatic patch and minor updates, improving flexibility.
Why: The suggestion correctly points out that using a fixed version 2.19 is restrictive and proposes a more flexible version constraint ^2.19.0, which aligns with standard Helm practices and the previous versioning scheme.
Low
Learned best practice
Validate required version inputs
Add Makefile guards to fail fast if any KEDA version/tag variable is empty, and ensure the previous tag variable matches the tag format your release flow expects (to avoid pushing/tagging incorrect images).
-KEDA_TAG_PREV_VERSION := $(or $(KEDA_TAG_PREV_VERSION),$(KEDA_TAG_PREV_VERSION),2.18.0)+KEDA_TAG_PREV_VERSION := $(or $(KEDA_TAG_PREV_VERSION),$(KEDA_TAG_PREV_VERSION),2.18.0-selenium-grid)
KEDA_CORE_VERSION := $(or $(KEDA_CORE_VERSION),$(KEDA_CORE_VERSION),2.19.0)
KEDA_TAG_VERSION := $(or $(KEDA_TAG_VERSION),$(KEDA_TAG_VERSION),2.19.0)
+$(if $(strip $(KEDA_CORE_VERSION)),,$(error KEDA_CORE_VERSION must be non-empty))+$(if $(strip $(KEDA_TAG_VERSION)),,$(error KEDA_TAG_VERSION must be non-empty))+$(if $(strip $(KEDA_TAG_PREV_VERSION)),,$(error KEDA_TAG_PREV_VERSION must be non-empty))+
Apply / Chat
Suggestion importance[1-10]: 6
__
Why:
Relevant best practice - When tagging/downloading external tooling/artifacts, pin the intended version and validate that version/tag inputs are correct and non-empty.
The workflow failed during make setup_dev_env (Makefile:67) while running ./tests/charts/make/chart_setup_env.sh.
The script attempted to set KUBERNETES_VERSION via curl -L -s https://dl.k8s.io/release/stable.txt, but the request returned a timeout message instead of a version string (Timed out while waiting on cache-iad-kiad7000081-IAD).
That timeout text was then interpolated into the kubectl download URL, producing an invalid URL:
curl failed with curl: (3) URL rejected: Malformed input to a URL function, triggering the script’s on_failure trap and exiting with status 3, which caused make setup_dev_env to fail.
The retry wrapper (nick-invision/retry@master) retried 3 times, but each attempt hit the same network timeout/invalid URL issue; the final attempt failed and the action stopped.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User description
Thanks for contributing to the Docker-Selenium project!
A PR well described will help maintainers to quickly review and merge it
Before submitting your PR, please check our contributing guidelines, applied for this repository.
Avoid large PRs, help reviewers by making them as simple and short as possible.
Description
Motivation and Context
Types of changes
Checklist
PR Type
Enhancement
Description
Update KEDA from 2.17.2 to 2.19.0 with official kedacore registry
Switch from custom selenium-based KEDA images to official kedacore images
Add Chrome 143, Firefox 145-146, and Edge 143 browser versions
Fix typo in test case and update Helm chart dependencies
Diagram Walkthrough
File Walkthrough
Makefile
Update KEDA version and registry configurationMakefile
dependencies
Chart.yaml
Update KEDA Helm chart dependency versioncharts/selenium-grid/Chart.yaml
README.md
Update KEDA image registry and version documentation.keda/README.md
of selenium registry
values
CONFIGURATION.md
Update KEDA dependency version constraintcharts/selenium-grid/CONFIGURATION.md
multiple-nodes-platform-version.yaml
Add latest browser versions to multi-node configurationcharts/selenium-grid/multiple-nodes-platform-version.yaml
145.0-20260120 and 146.0-20260120
selenium_grid_scaler_test.go
Fix typo in test case name.keda/scalers/selenium_grid_scaler_test.go