You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Thanks for contributing to the Docker-Selenium project! A PR well described will help maintainers to quickly review and merge it
Before submitting your PR, please check our contributing guidelines, applied for this repository.
Avoid large PRs, help reviewers by making them as simple and short as possible.
Installs fonts-thai-tlwg-ttf for Thai text rendering support
Diagram Walkthrough
flowchart LR
A["NodeBase Dockerfile"] -- "adds Thai font package" --> B["fonts-thai-tlwg-ttf dependency"]
B -- "enables" --> C["Thai language support"]
Loading
File Walkthrough
Relevant files
Dependencies
Dockerfile
Add Thai font package to dependencies
NodeBase/Dockerfile
Added fonts-thai-tlwg-ttf package to apt-get install command
Placed in locale and encoding settings section alongside other font packages
Enables Thai language text rendering in Docker container
Fix Thai text rendering being incorrect when using selenium/node-chrome:142.0 in Selenium Grid (i.e., ensure Thai glyphs display correctly in Chrome inside the container).
⚪
Confirm in a running container based on the updated image that Thai text on the reported page renders correctly (visual/UI verification and/or screenshot comparison), including in VNC/noVNC sessions.
Codebase Duplication Compliance
⚪
Codebase context is not defined
Follow the guide to enable codebase context checks.
Custom Compliance
🟢
Generic: Comprehensive Audit Trails
Objective: To create a detailed and reliable record of critical system actions for security analysis and compliance.
Why: The suggestion correctly points out that the font cache needs to be rebuilt using fc-cache after installing new fonts, which is a crucial step to make them available to applications in the container.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User description
Thanks for contributing to the Docker-Selenium project!
A PR well described will help maintainers to quickly review and merge it
Before submitting your PR, please check our contributing guidelines, applied for this repository.
Avoid large PRs, help reviewers by making them as simple and short as possible.
Description
Fixes #3043
Motivation and Context
Types of changes
Checklist
PR Type
Enhancement
Description
Add Thai language font package to Docker image
Installs fonts-thai-tlwg-ttf for Thai text rendering support
Diagram Walkthrough
File Walkthrough
Dockerfile
Add Thai font package to dependenciesNodeBase/Dockerfile
fonts-thai-tlwg-ttfpackage to apt-get install commandpackages