You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Thanks for contributing to the Docker-Selenium project! A PR well described will help maintainers to quickly review and merge it
Before submitting your PR, please check our contributing guidelines, applied for this repository.
Avoid large PRs, help reviewers by making them as simple and short as possible.
Description
Motivation and Context
Types of changes
Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)
Objective: To create a detailed and reliable record of critical system actions for security analysis and compliance.
Status: No audit scope: The changes add Docker and Helm configuration without introducing or modifying application logic where audit trails would apply, so audit compliance cannot be assessed from this diff.
Generic: Robust Error Handling and Edge Case Management
Objective: Ensure comprehensive error handling that provides meaningful context and graceful degradation
Status: No error paths: The added lines only update ARG versions in a Dockerfile and do not introduce executable logic where error handling or edge case management would be present, so compliance cannot be determined from this diff.
Objective: To prevent the leakage of sensitive system information through error messages while providing sufficient detail for internal debugging.
Status: No user errors: The changes are configuration entries and do not expose user-facing error handling, so secure error handling compliance cannot be evaluated from this diff.
Objective: To ensure logs are useful for debugging and auditing without exposing sensitive information like PII, PHI, or cardholder data.
Status: No logging shown: The diff only adds dependency versions and Helm node entries and does not include any logging statements to assess for sensitive data exposure or structure.
Generic: Security-First Input Validation and Data Handling
Objective: Ensure all data inputs are validated, sanitized, and handled securely to prevent vulnerabilities
Status: Config only change: The added lines update build ARGs and Helm values without introducing input handling or data processing code, so validation and data handling security cannot be verified from this diff.
The action failed because the make target test_video_integrity detected corrupted MP4 files produced during the Docker-based tests, causing make test_standalone_docker to exit with code 2. - The ffmpeg integrity check reported “moov atom not found” for multiple videos, indicating invalid/corrupted MP4s. - Examples: - ./tests/videos/upload/test_with_frames_ChromeTests.mp4 — moov atom not found
- ./tests/videos/upload/test_title_FirefoxTests.mp4 — moov atom not found - ./tests/videos/upload/test_title_and_maximize_window_FirefoxTests.mp4 — moov atom not found - ./tests/videos/upload/test_select_from_a_dropdown_ChromeTests.mp4 — moov atom not found - First attempt: Number of corrupted video files: 4 (Makefile:1177 -> target test_video_integrity error; Makefile:1097 -> test_node_docker; Makefile:1088 -> test_standalone_docker) - Second attempt: Number of corrupted video files: 7 (same failure path) - Final error: “Final attempt failed. Child_process exited with error code 2”
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User description
Thanks for contributing to the Docker-Selenium project!
A PR well described will help maintainers to quickly review and merge it
Before submitting your PR, please check our contributing guidelines, applied for this repository.
Avoid large PRs, help reviewers by making them as simple and short as possible.
Description
Motivation and Context
Types of changes
Checklist
PR Type
Enhancement
Description
Update OpenTelemetry from 1.55.0 to 1.56.0
Update gRPC from 1.76.0 to 1.77.0
Update Envsubst from 1.4.7 to 1.4.8
Update cURL from 8.16.0 to 8.17.0
Add Chrome 142 and Edge 142 nodes to Helm chart
Diagram Walkthrough
File Walkthrough
Dockerfile
Update dependency versions in DockerfileBase/Dockerfile
multiple-nodes-platform-version.yaml
Add Chrome 142 and Edge 142 node configurationscharts/selenium-grid/multiple-nodes-platform-version.yaml