You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Thanks for contributing to the Docker-Selenium project! A PR well described will help maintainers to quickly review and merge it
Before submitting your PR, please check our contributing guidelines, applied for this repository.
Avoid large PRs, help reviewers by making them as simple and short as possible.
Description
Motivation and Context
Types of changes
Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)
Objective: To create a detailed and reliable record of critical system actions for security analysis and compliance.
Status: Logging Context: The change toggles test configuration flags only, and there is no evidence of audit logging for critical actions in the added lines, which may be outside the scope of this Makefile target.
Generic: Robust Error Handling and Edge Case Management
Objective: Ensure comprehensive error handling that provides meaningful context and graceful degradation
Status: Missing Error Handling: The Makefile command lines do not include explicit error handling or checks for missing environment variables, but such handling may be defined in the called script.
Objective: To prevent the leakage of sensitive system information through error messages while providing sufficient detail for internal debugging.
Status: Error Exposure Unknown: The Makefile target does not show user-facing error messages; potential exposure depends on the invoked script's behavior, which is not visible in this diff.
Objective: To ensure logs are useful for debugging and auditing without exposing sensitive information like PII, PHI, or cardholder data.
Status: Logging Undefined: The Makefile target passes many env vars to a script but shows no logging configuration; whether sensitive data is logged depends on the script's implementation, not visible here.
Generic: Security-First Input Validation and Data Handling
Objective: Ensure all data inputs are validated, sanitized, and handled securely to prevent vulnerabilities
Status: Env Validation: The Makefile sets numerous environment variables for the test run without visible validation or sanitization; correctness and safety depend on downstream script validation not shown here.
Failed test name: SeleniumTests.ChromeTests.test_download_file
Failure summary:
The action failed because the Selenium test test_download_file errored in two separate attempts (NodeChrome and NodeAllChrome runs): - The test waits for downloadable files via driver.get_downloadable_files() and expects a file ending with some-file.txt. - Selenium Grid Node returned an error when trying to read a download-in-progress temp file path ending with .crdownload, which did not exist by the time it tried to stat it: - Exception: selenium.common.exceptions.WebDriverException: Message: Failed to get file attributes: /tmp//download.../some-file.txt.crdownload - Root cause: java.nio.file.NoSuchFileException at org.openqa.selenium.grid.node.local.LocalNode.getFileInfo(LocalNode.java:807) (stack also references LocalNode.listDownloadedFiles and downloadFile). - This indicates a race condition or mismatch between expected file name (.crdownload vs final name) during the download check in tests/SeleniumTests/init.py line 131 (the lambda used in the wait), causing the test to fail and the Make targets test_chrome and test_node_all_browsers to exit with errors.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User description
Thanks for contributing to the Docker-Selenium project!
A PR well described will help maintainers to quickly review and merge it
Before submitting your PR, please check our contributing guidelines, applied for this repository.
Avoid large PRs, help reviewers by making them as simple and short as possible.
Description
Motivation and Context
Types of changes
Checklist
PR Type
Tests
Description
Disable multiple versions testing in autoscaling deployment HTTPS chart test
Changes
TEST_MULTIPLE_VERSIONSfrom true to false in MakefileDiagram Walkthrough
File Walkthrough
Makefile
Disable multiple versions in chart testMakefile
chart_test_autoscaling_deployment_httpstargetTEST_MULTIPLE_VERSIONS=truetoTEST_MULTIPLE_VERSIONS=falsewith HTTPS