You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Thanks for contributing to the Docker-Selenium project! A PR well described will help maintainers to quickly review and merge it
Before submitting your PR, please check our contributing guidelines, applied for this repository.
Avoid large PRs, help reviewers by making them as simple and short as possible.
Language Support: All standardized Unicode emoji sets.
fonts-noto
Purpose: A powerful meta-package that installs a vast collection of Noto fonts for scripts worldwide, ensuring maximum compatibility.
Key Language/Script Support Includes:
South & Southeast Asian: Thai, Devanagari (Hindi), Bengali, Tamil, Telugu, Khmer, Lao, Burmese, etc.
Middle Eastern: Arabic, Hebrew, Persian.
Caucasus & Central Asian: Armenian, Georgian.
...and dozens of other scripts from around the globe.
Summary
By combining these packages, our application can now correctly render text from virtually any language, improving user experience and international compatibility. This change makes our font stack more reliable and future-proof.
Motivation and Context
Types of changes
Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)
The removal of specific font packages like fonts-liberation, fonts-ipafont-gothic, fonts-wqy-zenhei, fonts-tlwg-loma-otf, and fonts-indic may reduce language and character coverage. Should verify that fonts-noto provides equivalent coverage for all previously supported languages and scripts.
The sed command updates Fluxbox style to use "Noto Sans CJK" but the comment still references "fonts-wqy-zenhei" which was removed. This inconsistency should be addressed and the font availability should be verified.
# For Fluxbox style, use fonts-wqy-zenhei which has a large international language coverage
&& sed -i 's/Ubuntu-/Noto Sans CJK-/g' /usr/share/fluxbox/styles/ubuntu-light \
The action failed because the video integrity test could not find any video files to verify. The test expects to find .mp4 files in the ./tests/videos directory, but the search returned 0 files. This caused the test to exit with error code 1 at line 25783/25801/26482 in the Makefile target test_video_integrity. The failure occurred consistently across all 3 retry attempts, indicating that the video recording functionality is not working properly or the video files are not being saved to the expected location.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User description
Thanks for contributing to the Docker-Selenium project!
A PR well described will help maintainers to quickly review and merge it
Before submitting your PR, please check our contributing guidelines, applied for this repository.
Avoid large PRs, help reviewers by making them as simple and short as possible.
Description
Fixes #2913
By standardizing on the Google Noto font family, we ensure consistent text rendering and prevent missing character issues (i.e., "tofu" boxes
□).The following packages have been included to achieve this:
Package Breakdown and Language Coverage
fonts-noto-corefonts-noto-cjkfonts-noto-color-emojifonts-notoSummary
By combining these packages, our application can now correctly render text from virtually any language, improving user experience and international compatibility. This change makes our font stack more reliable and future-proof.
Motivation and Context
Types of changes
Checklist
PR Type
Enhancement
Description
Simplified font package installation in Docker image
Replaced multiple specific font packages with unified
fonts-notoUpdated Fluxbox style configuration to use Noto fonts
Diagram Walkthrough
File Walkthrough
Dockerfile
Consolidate font packages to Noto familyNodeBase/Dockerfile
language-pack-en,xfonts-scalable,fonts-ubuntu, etc.)fonts-noto,fonts-noto-color-emoji,fonts-noto-cjk"WenQuanYi Zen Hei"