You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Thanks for contributing to the Docker-Selenium project! A PR well described will help maintainers to quickly review and merge it
Before submitting your PR, please check our contributing guidelines, applied for this repository.
Avoid large PRs, help reviewers by making them as simple and short as possible.
Description
Motivation and Context
Types of changes
Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)
Change CI runner from blacksmith-8vcpu-ubuntu-2204 to ubuntu-22.04
Add disk space cleanup configuration options
Changes diagram
flowchart LR
A["blacksmith-8vcpu-ubuntu-2204"] -- "changed to" --> B["ubuntu-22.04"]
B --> C["Free Disk Space Action"]
C --> D["Added cleanup options"]
Loading
Changes walkthrough 📝
Relevant files
Configuration changes
deploy.yml
Update CI runner and disk cleanup configuration
.github/workflows/deploy.yml
Changed runner from blacksmith-8vcpu-ubuntu-2204 to ubuntu-22.04
Added configuration options for free-disk-space action
Enabled cleanup of android, dotnet, haskell, large-packages, docker-images, and swap-storage
Switching from blacksmith-8vcpu-ubuntu-2204 (8 vCPUs) to ubuntu-22.04 (2 vCPUs) may significantly impact build and deployment performance. Consider whether the reduced compute resources will affect deployment times and success rates.
Enabling docker-images cleanup in the free-disk-space action may remove Docker images that could be needed later in the deployment process. Verify that this won't interfere with subsequent Docker operations.
Using @main for the free-disk-space action is risky as it points to the latest unstable version. Pin to a specific version tag or commit SHA to ensure reproducible builds and avoid potential breaking changes.
Why: The suggestion correctly identifies that using @main for a GitHub Action can lead to instability and recommends pinning to a specific version, which is a crucial best practice for ensuring reproducible builds.
The action failed because the video integrity test could not find any video files to verify. The test expects to find .mp4 files in the ./tests/videos directory, but the directory was empty. The test script exits with error code 1 when no video files are found, causing the make command test_video_integrity to fail. This suggests that either: • Video recording was not properly enabled during the test execution • The video files were not saved to the expected location • There was an issue with the video recording functionality in the Selenium Grid setup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User description
Thanks for contributing to the Docker-Selenium project!
A PR well described will help maintainers to quickly review and merge it
Before submitting your PR, please check our contributing guidelines, applied for this repository.
Avoid large PRs, help reviewers by making them as simple and short as possible.
Description
Motivation and Context
Types of changes
Checklist
PR Type
Other
Description
Change CI runner from blacksmith-8vcpu-ubuntu-2204 to ubuntu-22.04
Add disk space cleanup configuration options
Changes diagram
Changes walkthrough 📝
deploy.yml
Update CI runner and disk cleanup configuration.github/workflows/deploy.yml
docker-images, and swap-storage