include notebook nbqa as part of python lint

[RafalSkolasinski]

What this PR does / why we need it:

Includes nbqa as part of python lint

Which issue(s) this PR fixes:

Fixes #2885

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

[axsaucedo]

/approve

[seldondev]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: axsaucedo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [axsaucedo]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[MarcoGorelli]

Just FYI, black now has a Jupyter hook, I'd advise switching to that from nbqa-black

[RafalSkolasinski]

Hey @MarcoGorelli, thanks for the tip. I think currently we also use nbqa to call isort on notebooks - do you also plan to contribute that to the upstream project?

We adopted nbqa mostly to run black in notebooks indeed. Is your plan for nbqa to just contribute to upstream tools what they're missing and keep nbqa as a fallback?

[MarcoGorelli]

Is your plan for nbqa to just contribute to upstream tools what they're missing and keep nbqa as a fallback?

Some (pyupgrade, mypy, flake8, pylint) would either certainly or almost certainly not accept a PR to support notebooks directly, so I'll keep maintaining nbqa for them.

I'd like to suggest this to isort too, but not in the near future