Allow users to manage their own painting (closes #171) #235
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
er how do you convert to draft fuck |
Contributor
Author
|
incredible, sorry for the review ping lmao |
msparkles
force-pushed
the
feat/custom-paint
branch
2 times, most recently
from
c27bea8 to
1136fcc
Compare
msparkles
force-pushed
the
feat/custom-paint
branch
from
1136fcc to
baa8720
Compare
add the ability to track user paint calls add a struct called Globals to simplify the logic, and add globals to PaintDom for users to attach custom renderers to add a debug assertion to detect when paint_all() is called more than once a frame add several comments to declare what parts of the painting functions are yakui's and what parts are supposed to be modified, to allow users to track rendering changes from upstream more easily, and to declare what parts of the functions should be considered API-changing if altered add several helper functions in the rendering backends in order to simplify the rendering function to something users can copy entirely into their code without copying anything else add examples for the custom rendering publicize multiple important types and fields and functions in order to allow users to handle rendering themselves publicize important fields previously exposed via functions to allow Rust to understand the partial borrowing introduce new structs to solve the aforementioned partial borrowing issue lift the clipping rect of a draw call outside of the draw call struct lift rendering functions up to top-level to make copying the function into user's own code easier fix disjointed docs & reorganize related functions
fix the weird ungrammatical comment on main() use yakui::Rect in the file
msparkles
force-pushed
the
feat/custom-paint
branch
from
baa8720 to
fcad7c5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reopened from #223 (we moved the repo from forking from automancy's fork to forking from upstream instead because of weird Github shenanigans)