Update winit to 0.31.0 #226
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rickvanprim
requested review from
LPGhatguy,
Ralith and
kanerogers
as code owners
Ralith
requested changes
Jun 14, 2025
Collaborator
Ralith
left a comment
Ralith
left a comment
There was a problem hiding this comment.
Thanks for working on this! Is the 0.31 release expected soon?
Comment on lines
+39
to
+41
| trait App { | ||
| fn render(&mut self, gui_state: &GuiState); | ||
| } |
Collaborator
There was a problem hiding this comment.
This abstraction is unhelpful:
- In an example, there can only ever possibly be one implementation
- This library is intended for direct use in applications, which will also not need anything like this
- Hypothetical framework-style downstreams will need something much more complex than this
Please simplify.
Contributor
Author
No clue unfortunately. Based on https://github.com/rust-windowing/winit/milestone/18 I'm guessing it's still a ways off. I expect this PR/branch to just sit as a draft until the release. I went through the trouble of upgrading my repo (which required also upgrading |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.