Bug fix for "Constant Point Size" not working if PathCreator object isn't at World Zero.#103
Open
ChimeraReyat wants to merge 1 commit intoSebLague:masterfrom
Open
Bug fix for "Constant Point Size" not working if PathCreator object isn't at World Zero.#103ChimeraReyat wants to merge 1 commit intoSebLague:masterfrom
ChimeraReyat wants to merge 1 commit intoSebLague:masterfrom
Conversation
…handle position; this fixes a bug where Constant Point Size was incorrect if the PathCreator Game Object's Location was not at World Zero.
JerryVerhoeven
added a commit
to JerryVerhoeven/Path-Creator
that referenced
this pull request
Sep 18, 2023
Bug fix for "Constant Point Size" not working if PathCreator object isn't at World Zero. SebLague#103
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In PathEditor.cs, the variables
handleRadiusinProcessBezierPathInput, andanchor/controlHandleSizeinDrawHandle, previously referenced the raw bezierPath position information based on which index was requested, rather than the transformed position--this is curious, considering the transform position is calculated after handleRadius and before anchor/controlHandleSize are set.As a result, Constant Point Size failed to display correctly if the GameObject for PathCreator was ever anywhere but [0,0,0], causing strange deformations in the point's sizes when moving/rotating the camera. Viewable below.
2021-05-25.23-43-43.mp4
From my testing, this doesn't seem to introduce any new issues, and as seen in the below video, the issue appears to be corrected.
2021-05-25.23-44-01.mp4